mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-14 04:49:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Raise error on unhandled rejected promises (#1010)

Browse Source 
* deal with unhandled rejected promise

* use Vector<Strong<JSPromise>> to store rejected promises
This commit is contained in:
Zilin Zhu
2022-08-09 01:58:00 +08:00
committed by GitHub
parent 98c2d20ab0
commit 02644ab65a
8 changed files with 58 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/bun.js/javascript.zig
View File

@@ -272,6 +272,7 @@ comptime {
_ = Bun__getVM;
_ = Bun__drainMicrotasks;
_ = Bun__queueMicrotask;
_ = Bun__handleRejectedPromise;
_ = Bun__readOriginTimer;
}
}
@@ -280,6 +281,11 @@ pub export fn Bun__queueMicrotask(global: *JSGlobalObject, task: *JSC.CppTask) v
global.bunVM().eventLoop().enqueueTask(Task.init(task));
}
pub export fn Bun__handleRejectedPromise(global: *JSGlobalObject, promise: *JSC.JSPromise) void {
const result = promise.result(global.vm());
global.bunVM().runErrorHandler(result, null);
}
// If you read JavascriptCore/API/JSVirtualMachine.mm - https://github.com/WebKit/WebKit/blob/acff93fb303baa670c055cb24c2bad08691a01a0/Source/JavaScriptCore/API/JSVirtualMachine.mm#L101
// We can see that it's sort of like std.mem.Allocator but for JSGlobalContextRef, to support Automatic Reference Counting
// Its unavailable on Linux