mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-15 21:32:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update to zig 0.15.2 (#24204)

Browse Source 
Fixes ENG-21287

Build times, from `bun run build && echo '//' >> src/main.zig && time
bun run build`

|Platform|0.14.1|0.15.2|Speedup|
|-|-|-|-|
|macos debug asan|126.90s|106.27s|1.19x|
|macos debug noasan|60.62s|50.85s|1.19x|
|linux debug asan|292.77s|241.45s|1.21x|
|linux debug noasan|146.58s|130.94s|1.12x|
|linux debug use_llvm=false|n/a|78.27s|1.87x|
|windows debug asan|177.13s|142.55s|1.24x|

Runtime performance:

- next build memory usage may have gone up by 5%. Otherwise seems the
same. Some code with writers may have gotten slower, especially one
instance of a counting writer and a few instances of unbuffered writers
that now have vtable overhead.
- File size reduced by 800kb (from 100.2mb to 99.4mb)

Improvements:

- `@export` hack is no longer needed for watch
- native x86_64 backend for linux builds faster. to use it, set use_llvm
false and no_link_obj false. also set `ASAN_OPTIONS=detect_leaks=0`
otherwise it will spam the output with tens of thousands of lines of
debug info errors. may need to use the zig lldb fork for debugging.
- zig test-obj, which we will be able to use for zig unit tests

Still an issue:

- false 'dependency loop' errors remain in watch mode
- watch mode crashes observed

Follow-up:

- [ ] search `comptime Writer: type` and `comptime W: type` and remove
- [ ] remove format_mode in our zig fork
- [ ] remove deprecated.zig autoFormatLabelFallback
- [ ] remove deprecated.zig autoFormatLabel
- [ ] remove deprecated.BufferedWriter and BufferedReader
- [ ] remove override_no_export_cpp_apis as it is no longer needed
- [ ] css Parser(W) -> Parser, and remove all the comptime writer: type
params
- [ ] remove deprecated writer fully

Files that add lines:

```
649     src/deprecated.zig
167     scripts/pack-codegen-for-zig-team.ts
54      scripts/cleartrace-impl.js
46      scripts/cleartrace.ts
43      src/windows.zig
18      src/fs.zig
17      src/bun.js/ConsoleObject.zig
16      src/output.zig
12      src/bun.js/test/debug.zig
12      src/bun.js/node/node_fs.zig
8       src/env_loader.zig
7       src/css/printer.zig
7       src/cli/init_command.zig
7       src/bun.js/node.zig
6       src/string/escapeRegExp.zig
6       src/install/PnpmMatcher.zig
5       src/bun.js/webcore/Blob.zig
4       src/crash_handler.zig
4       src/bun.zig
3       src/install/lockfile/bun.lock.zig
3       src/cli/update_interactive_command.zig
3       src/cli/pack_command.zig
3       build.zig
2       src/Progress.zig
2       src/install/lockfile/lockfile_json_stringify_for_debugging.zig
2       src/css/small_list.zig
2       src/bun.js/webcore/prompt.zig
1       test/internal/ban-words.test.ts
1       test/internal/ban-limits.json
1       src/watcher/WatcherTrace.zig
1       src/transpiler.zig
1       src/shell/builtin/cp.zig
1       src/js_printer.zig
1       src/io/PipeReader.zig
1       src/install/bin.zig
1       src/css/selectors/selector.zig
1       src/cli/run_command.zig
1       src/bun.js/RuntimeTranspilerStore.zig
1       src/bun.js/bindings/JSRef.zig
1       src/bake/DevServer.zig
```

Files that remove lines:

```
-1      src/test/recover.zig
-1      src/sql/postgres/SocketMonitor.zig
-1      src/sql/mysql/MySQLRequestQueue.zig
-1      src/sourcemap/CodeCoverage.zig
-1      src/css/values/color_js.zig
-1      src/compile_target.zig
-1      src/bundler/linker_context/convertStmtsForChunk.zig
-1      src/bundler/bundle_v2.zig
-1      src/bun.js/webcore/blob/read_file.zig
-1      src/ast/base.zig
-2      src/sql/postgres/protocol/ArrayList.zig
-2      src/shell/builtin/mkdir.zig
-2      src/install/PackageManager/patchPackage.zig
-2      src/install/PackageManager/PackageManagerDirectories.zig
-2      src/fmt.zig
-2      src/css/declaration.zig
-2      src/css/css_parser.zig
-2      src/collections/baby_list.zig
-2      src/bun.js/bindings/ZigStackFrame.zig
-2      src/ast/E.zig
-3      src/StandaloneModuleGraph.zig
-3      src/deps/picohttp.zig
-3      src/deps/libuv.zig
-3      src/btjs.zig
-4      src/threading/Futex.zig
-4      src/shell/builtin/touch.zig
-4      src/meta.zig
-4      src/install/lockfile.zig
-4      src/css/selectors/parser.zig
-5      src/shell/interpreter.zig
-5      src/css/error.zig
-5      src/bun.js/web_worker.zig
-5      src/bun.js.zig
-6      src/cli/test_command.zig
-6      src/bun.js/VirtualMachine.zig
-6      src/bun.js/uuid.zig
-6      src/bun.js/bindings/JSValue.zig
-9      src/bun.js/test/pretty_format.zig
-9      src/bun.js/api/BunObject.zig
-14     src/install/install_binding.zig
-14     src/fd.zig
-14     src/bun.js/node/path.zig
-14     scripts/pack-codegen-for-zig-team.sh
-17     src/bun.js/test/diff_format.zig
```

`git diff --numstat origin/main...HEAD | awk '{ print ($1-$2)"\t"$3 }' |
sort -rn`

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
Co-authored-by: Meghan Denny <meghan@bun.com>
Co-authored-by: tayor.fish <contact@taylor.fish>
This commit is contained in:
pfg
2025-11-10 14:38:26 -08:00
committed by GitHub
parent 143ad2ea58
commit 05d0475c6c
558 changed files with 6102 additions and 5212 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/cli/create_command.zig
View File

@@ -493,11 +493,11 @@ pub const CreateCommand = struct {
}
if (bun.windows.Win32Error.get().toSystemErrno()) |err| {
Output.err(err, "failed to copy file {}", .{
Output.err(err, "failed to copy file {f}", .{
bun.fmt.fmtOSPath(entry.path, .{}),
});
} else {
Output.errGeneric("failed to copy file {}", .{
Output.errGeneric("failed to copy file {f}", .{
bun.fmt.fmtOSPath(entry.path, .{}),
});
}
@@ -520,7 +520,7 @@ pub const CreateCommand = struct {
break :brk destination_dir_.createFile(entry.path, .{}) catch |err| {
node_.end();
progress_.refresh();
Output.err(err, "failed to copy file {}", .{bun.fmt.fmtOSPath(entry.path, .{})});
Output.err(err, "failed to copy file {f}", .{bun.fmt.fmtOSPath(entry.path, .{})});
Global.crash();
};
});
@@ -541,7 +541,7 @@ pub const CreateCommand = struct {
CopyFile.copyFile(infile, outfile).unwrap() catch |err| {
node_.end();
progress_.refresh();
Output.err(err, "failed to copy file {}", .{bun.fmt.fmtOSPath(entry.path, .{})});
Output.err(err, "failed to copy file {f}", .{bun.fmt.fmtOSPath(entry.path, .{})});
Global.crash();
};
}
@@ -666,7 +666,7 @@ pub const CreateCommand = struct {
break :process_package_json;
}
var properties_list = std.ArrayList(js_ast.G.Property).fromOwnedSlice(default_allocator, package_json_expr.data.e_object.properties.slice());
var properties_list = std.array_list.Managed(js_ast.G.Property).fromOwnedSlice(default_allocator, package_json_expr.data.e_object.properties.slice());
if (ctx.log.errors > 0) {
try ctx.log.print(Output.errorWriter());
@@ -1109,7 +1109,7 @@ pub const CreateCommand = struct {
// "bun.macros"
// if (needs_bun_macros_prop and !needs_bun_prop) {
// var obj = bun_prop.?.data.e_object;
// var properties = try std.ArrayList(js_ast.G.Property).initCapacity(
// var properties = try std.array_list.Managed(js_ast.G.Property).initCapacity(
// ctx.allocator,
// obj.properties.len + InjectionPrefill.bun_macros_relay_object.properties.len,
// );
@@ -1137,7 +1137,7 @@ pub const CreateCommand = struct {
// if (needs_to_inject_dependency) {
// defer needs_to_inject_dependency = false;
// var obj = dependencies.?.data.e_object;
// var properties = try std.ArrayList(js_ast.G.Property).initCapacity(
// var properties = try std.array_list.Managed(js_ast.G.Property).initCapacity(
// ctx.allocator,
// obj.properties.len + dependencies_to_inject_count,
// );
@@ -1152,7 +1152,7 @@ pub const CreateCommand = struct {
// if (needs_to_inject_dev_dependency) {
// defer needs_to_inject_dev_dependency = false;
// var obj = dev_dependencies.?.data.e_object;
// var properties = try std.ArrayList(js_ast.G.Property).initCapacity(
// var properties = try std.array_list.Managed(js_ast.G.Property).initCapacity(
// ctx.allocator,
// obj.properties.len + dev_dependencies_to_inject_count,
// );
@@ -1185,7 +1185,7 @@ pub const CreateCommand = struct {
// var public_index_html_parts = [_]string{ destination, "public/index.html" };
// var public_index_html_path = filesystem.absBuf(&public_index_html_parts, &bun_path_buf);
// const public_index_html_file = std.fs.openFileAbsolute(public_index_html_path, .{ .mode = .read_write }) catch break :bail;
// const public_index_html_file = std.fs.cwd().openFile(public_index_html_path, .{ .mode = .read_write }) catch break :bail;
// defer public_index_html_file.close();
// const file_extensions_to_try = [_]string{ ".tsx", ".ts", ".jsx", ".js", ".mts", ".mcjs" };
@@ -1212,7 +1212,7 @@ pub const CreateCommand = struct {
// var body_closing_tag: usize = std.mem.lastIndexOf(u8, public_index_file_contents, "</body>") orelse break :bail;
// var public_index_file_out = std.ArrayList(u8).initCapacity(ctx.allocator, public_index_file_contents.len) catch break :bail;
// var public_index_file_out = std.array_list.Managed(u8).initCapacity(ctx.allocator, public_index_file_contents.len) catch break :bail;
// var html_writer = public_index_file_out.writer();
// _ = html_writer.writeAll(public_index_file_contents[0..body_closing_tag]) catch break :bail;
@@ -1251,7 +1251,7 @@ pub const CreateCommand = struct {
// // bun.copy(u8, bun_path_buf[destination.len + "/src/index".len ..], ".css");
// // var index_css_file_path = bun_path_buf[0 .. destination.len + "/src/index.css".len];
// // std.fs.accessAbsolute(index_css_file_path, .{}) catch break :inject_css;
// // var list = std.ArrayList(u8).fromOwnedSlice(ctx.allocator, outfile);
// // var list = std.array_list.Managed(u8).fromOwnedSlice(ctx.allocator, outfile);
// // list.insertSlice(head_i + "<head>".len, "<link rel=\"stylesheet\" href=\"/src/index.css\">\n") catch break :inject_css;
// // outfile =try list.toOwnedSlice();
// // }
@@ -1862,11 +1862,11 @@ pub const Example = struct {
}
}
pub fn fetchAllLocalAndRemote(ctx: Command.Context, node: ?*Progress.Node, env_loader: *DotEnv.Loader, filesystem: *fs.FileSystem) !std.ArrayList(Example) {
pub fn fetchAllLocalAndRemote(ctx: Command.Context, node: ?*Progress.Node, env_loader: *DotEnv.Loader, filesystem: *fs.FileSystem) !std.array_list.Managed(Example) {
const remote_examples = try Example.fetchAll(ctx, env_loader, node);
if (node) |node_| node_.end();
var examples = std.ArrayList(Example).fromOwnedSlice(ctx.allocator, remote_examples);
var examples = std.array_list.Managed(Example).fromOwnedSlice(ctx.allocator, remote_examples);
{
var folders = [3]std.fs.Dir{
bun.invalid_fd.stdDir(),