mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-14 12:51:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update to zig 0.15.2 (#24204)

Browse Source 
Fixes ENG-21287

Build times, from `bun run build && echo '//' >> src/main.zig && time
bun run build`

|Platform|0.14.1|0.15.2|Speedup|
|-|-|-|-|
|macos debug asan|126.90s|106.27s|1.19x|
|macos debug noasan|60.62s|50.85s|1.19x|
|linux debug asan|292.77s|241.45s|1.21x|
|linux debug noasan|146.58s|130.94s|1.12x|
|linux debug use_llvm=false|n/a|78.27s|1.87x|
|windows debug asan|177.13s|142.55s|1.24x|

Runtime performance:

- next build memory usage may have gone up by 5%. Otherwise seems the
same. Some code with writers may have gotten slower, especially one
instance of a counting writer and a few instances of unbuffered writers
that now have vtable overhead.
- File size reduced by 800kb (from 100.2mb to 99.4mb)

Improvements:

- `@export` hack is no longer needed for watch
- native x86_64 backend for linux builds faster. to use it, set use_llvm
false and no_link_obj false. also set `ASAN_OPTIONS=detect_leaks=0`
otherwise it will spam the output with tens of thousands of lines of
debug info errors. may need to use the zig lldb fork for debugging.
- zig test-obj, which we will be able to use for zig unit tests

Still an issue:

- false 'dependency loop' errors remain in watch mode
- watch mode crashes observed

Follow-up:

- [ ] search `comptime Writer: type` and `comptime W: type` and remove
- [ ] remove format_mode in our zig fork
- [ ] remove deprecated.zig autoFormatLabelFallback
- [ ] remove deprecated.zig autoFormatLabel
- [ ] remove deprecated.BufferedWriter and BufferedReader
- [ ] remove override_no_export_cpp_apis as it is no longer needed
- [ ] css Parser(W) -> Parser, and remove all the comptime writer: type
params
- [ ] remove deprecated writer fully

Files that add lines:

```
649     src/deprecated.zig
167     scripts/pack-codegen-for-zig-team.ts
54      scripts/cleartrace-impl.js
46      scripts/cleartrace.ts
43      src/windows.zig
18      src/fs.zig
17      src/bun.js/ConsoleObject.zig
16      src/output.zig
12      src/bun.js/test/debug.zig
12      src/bun.js/node/node_fs.zig
8       src/env_loader.zig
7       src/css/printer.zig
7       src/cli/init_command.zig
7       src/bun.js/node.zig
6       src/string/escapeRegExp.zig
6       src/install/PnpmMatcher.zig
5       src/bun.js/webcore/Blob.zig
4       src/crash_handler.zig
4       src/bun.zig
3       src/install/lockfile/bun.lock.zig
3       src/cli/update_interactive_command.zig
3       src/cli/pack_command.zig
3       build.zig
2       src/Progress.zig
2       src/install/lockfile/lockfile_json_stringify_for_debugging.zig
2       src/css/small_list.zig
2       src/bun.js/webcore/prompt.zig
1       test/internal/ban-words.test.ts
1       test/internal/ban-limits.json
1       src/watcher/WatcherTrace.zig
1       src/transpiler.zig
1       src/shell/builtin/cp.zig
1       src/js_printer.zig
1       src/io/PipeReader.zig
1       src/install/bin.zig
1       src/css/selectors/selector.zig
1       src/cli/run_command.zig
1       src/bun.js/RuntimeTranspilerStore.zig
1       src/bun.js/bindings/JSRef.zig
1       src/bake/DevServer.zig
```

Files that remove lines:

```
-1      src/test/recover.zig
-1      src/sql/postgres/SocketMonitor.zig
-1      src/sql/mysql/MySQLRequestQueue.zig
-1      src/sourcemap/CodeCoverage.zig
-1      src/css/values/color_js.zig
-1      src/compile_target.zig
-1      src/bundler/linker_context/convertStmtsForChunk.zig
-1      src/bundler/bundle_v2.zig
-1      src/bun.js/webcore/blob/read_file.zig
-1      src/ast/base.zig
-2      src/sql/postgres/protocol/ArrayList.zig
-2      src/shell/builtin/mkdir.zig
-2      src/install/PackageManager/patchPackage.zig
-2      src/install/PackageManager/PackageManagerDirectories.zig
-2      src/fmt.zig
-2      src/css/declaration.zig
-2      src/css/css_parser.zig
-2      src/collections/baby_list.zig
-2      src/bun.js/bindings/ZigStackFrame.zig
-2      src/ast/E.zig
-3      src/StandaloneModuleGraph.zig
-3      src/deps/picohttp.zig
-3      src/deps/libuv.zig
-3      src/btjs.zig
-4      src/threading/Futex.zig
-4      src/shell/builtin/touch.zig
-4      src/meta.zig
-4      src/install/lockfile.zig
-4      src/css/selectors/parser.zig
-5      src/shell/interpreter.zig
-5      src/css/error.zig
-5      src/bun.js/web_worker.zig
-5      src/bun.js.zig
-6      src/cli/test_command.zig
-6      src/bun.js/VirtualMachine.zig
-6      src/bun.js/uuid.zig
-6      src/bun.js/bindings/JSValue.zig
-9      src/bun.js/test/pretty_format.zig
-9      src/bun.js/api/BunObject.zig
-14     src/install/install_binding.zig
-14     src/fd.zig
-14     src/bun.js/node/path.zig
-14     scripts/pack-codegen-for-zig-team.sh
-17     src/bun.js/test/diff_format.zig
```

`git diff --numstat origin/main...HEAD | awk '{ print ($1-$2)"\t"$3 }' |
sort -rn`

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
Co-authored-by: Meghan Denny <meghan@bun.com>
Co-authored-by: tayor.fish <contact@taylor.fish>
This commit is contained in:
pfg
2025-11-10 14:38:26 -08:00
committed by GitHub
parent 143ad2ea58
commit 05d0475c6c
558 changed files with 6102 additions and 5212 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/cli/outdated_command.zig
View File

@@ -245,7 +245,7 @@ pub const OutdatedCommand = struct {
catalog_name_hash: u64,
behavior: Behavior,
};
var catalog_map = std.AutoHashMap(CatalogKey, std.ArrayList(PackageID)).init(allocator);
var catalog_map = std.AutoHashMap(CatalogKey, std.array_list.Managed(PackageID)).init(allocator);
defer catalog_map.deinit();
defer {
var iter = catalog_map.iterator();
@@ -263,7 +263,7 @@ pub const OutdatedCommand = struct {
const entry = try catalog_map.getOrPut(key);
if (!entry.found_existing) {
entry.value_ptr.* = std.ArrayList(PackageID).init(allocator);
entry.value_ptr.* = std.array_list.Managed(PackageID).init(allocator);
}
try entry.value_ptr.append(item.workspace_pkg_id);
} else {
@@ -290,7 +290,7 @@ pub const OutdatedCommand = struct {
const workspace_list = catalog_map.get(key) orelse continue;
if (workspace_list.items[0] != item.workspace_pkg_id) continue;
var workspace_names = std.ArrayList(u8).init(allocator);
var workspace_names = std.array_list.Managed(u8).init(allocator);
defer workspace_names.deinit();
const cat_name = dep.version.value.catalog.slice(string_buf);
@@ -378,7 +378,7 @@ pub const OutdatedCommand = struct {
const pkg_resolutions = packages.items(.resolution);
const pkg_dependencies = packages.items(.dependencies);
var version_buf = std.ArrayList(u8).init(bun.default_allocator);
var version_buf = std.array_list.Managed(u8).init(bun.default_allocator);
defer version_buf.deinit();
const version_writer = version_buf.writer();
@@ -457,23 +457,23 @@ pub const OutdatedCommand = struct {
if (package_name_len > max_name) max_name = package_name_len;
bun.handleOom(version_writer.print("{}", .{resolution.value.npm.version.fmt(string_buf)}));
bun.handleOom(version_writer.print("{f}", .{resolution.value.npm.version.fmt(string_buf)}));
if (version_buf.items.len > max_current) max_current = version_buf.items.len;
version_buf.clearRetainingCapacity();
if (update_version.unwrap()) |update_version_| {
bun.handleOom(version_writer.print("{}", .{update_version_.version.fmt(manifest.string_buf)}));
bun.handleOom(version_writer.print("{f}", .{update_version_.version.fmt(manifest.string_buf)}));
} else {
bun.handleOom(version_writer.print("{}", .{resolution.value.npm.version.fmt(manifest.string_buf)}));
bun.handleOom(version_writer.print("{f}", .{resolution.value.npm.version.fmt(manifest.string_buf)}));
}
const update_version_len = version_buf.items.len + (if (has_filtered_update) " *".len else 0);
if (update_version_len > max_update) max_update = update_version_len;
version_buf.clearRetainingCapacity();
if (latest.unwrap()) |latest_version| {
bun.handleOom(version_writer.print("{}", .{latest_version.version.fmt(manifest.string_buf)}));
bun.handleOom(version_writer.print("{f}", .{latest_version.version.fmt(manifest.string_buf)}));
} else {
bun.handleOom(version_writer.print("{}", .{resolution.value.npm.version.fmt(manifest.string_buf)}));
bun.handleOom(version_writer.print("{f}", .{resolution.value.npm.version.fmt(manifest.string_buf)}));
}
const latest_version_len = version_buf.items.len + (if (has_filtered_latest) " *".len else 0);
if (latest_version_len > max_latest) max_latest = latest_version_len;
@@ -617,7 +617,7 @@ pub const OutdatedCommand = struct {
Output.pretty("{s}", .{table.symbols.verticalEdge()});
for (0..column_left_pad) |_| Output.pretty(" ", .{});
bun.handleOom(version_writer.print("{}", .{resolution.value.npm.version.fmt(string_buf)}));
bun.handleOom(version_writer.print("{f}", .{resolution.value.npm.version.fmt(string_buf)}));
Output.pretty("{s}", .{version_buf.items});
for (version_buf.items.len..current_column_inside_length + column_right_pad) |_| Output.pretty(" ", .{});
version_buf.clearRetainingCapacity();
@@ -628,10 +628,10 @@ pub const OutdatedCommand = struct {
Output.pretty("{s}", .{table.symbols.verticalEdge()});
for (0..column_left_pad) |_| Output.pretty(" ", .{});
if (update.unwrap()) |update_version| {
bun.handleOom(version_writer.print("{}", .{update_version.version.fmt(manifest.string_buf)}));
Output.pretty("{s}", .{update_version.version.diffFmt(resolution.value.npm.version, manifest.string_buf, string_buf)});
bun.handleOom(version_writer.print("{f}", .{update_version.version.fmt(manifest.string_buf)}));
Output.pretty("{f}", .{update_version.version.diffFmt(resolution.value.npm.version, manifest.string_buf, string_buf)});
} else {
bun.handleOom(version_writer.print("{}", .{resolution.value.npm.version.fmt(string_buf)}));
bun.handleOom(version_writer.print("{f}", .{resolution.value.npm.version.fmt(string_buf)}));
Output.pretty("<d>{s}<r>", .{version_buf.items});
}
var update_version_len: usize = version_buf.items.len;
@@ -648,10 +648,10 @@ pub const OutdatedCommand = struct {
Output.pretty("{s}", .{table.symbols.verticalEdge()});
for (0..column_left_pad) |_| Output.pretty(" ", .{});
if (latest.unwrap()) |latest_version| {
bun.handleOom(version_writer.print("{}", .{latest_version.version.fmt(manifest.string_buf)}));
Output.pretty("{s}", .{latest_version.version.diffFmt(resolution.value.npm.version, manifest.string_buf, string_buf)});
bun.handleOom(version_writer.print("{f}", .{latest_version.version.fmt(manifest.string_buf)}));
Output.pretty("{f}", .{latest_version.version.diffFmt(resolution.value.npm.version, manifest.string_buf, string_buf)});
} else {
bun.handleOom(version_writer.print("{}", .{resolution.value.npm.version.fmt(string_buf)}));
bun.handleOom(version_writer.print("{f}", .{resolution.value.npm.version.fmt(string_buf)}));
Output.pretty("<d>{s}<r>", .{version_buf.items});
}
var latest_version_len: usize = version_buf.items.len;