mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-13 20:39:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update to zig 0.15.2 (#24204)

Browse Source 
Fixes ENG-21287

Build times, from `bun run build && echo '//' >> src/main.zig && time
bun run build`

|Platform|0.14.1|0.15.2|Speedup|
|-|-|-|-|
|macos debug asan|126.90s|106.27s|1.19x|
|macos debug noasan|60.62s|50.85s|1.19x|
|linux debug asan|292.77s|241.45s|1.21x|
|linux debug noasan|146.58s|130.94s|1.12x|
|linux debug use_llvm=false|n/a|78.27s|1.87x|
|windows debug asan|177.13s|142.55s|1.24x|

Runtime performance:

- next build memory usage may have gone up by 5%. Otherwise seems the
same. Some code with writers may have gotten slower, especially one
instance of a counting writer and a few instances of unbuffered writers
that now have vtable overhead.
- File size reduced by 800kb (from 100.2mb to 99.4mb)

Improvements:

- `@export` hack is no longer needed for watch
- native x86_64 backend for linux builds faster. to use it, set use_llvm
false and no_link_obj false. also set `ASAN_OPTIONS=detect_leaks=0`
otherwise it will spam the output with tens of thousands of lines of
debug info errors. may need to use the zig lldb fork for debugging.
- zig test-obj, which we will be able to use for zig unit tests

Still an issue:

- false 'dependency loop' errors remain in watch mode
- watch mode crashes observed

Follow-up:

- [ ] search `comptime Writer: type` and `comptime W: type` and remove
- [ ] remove format_mode in our zig fork
- [ ] remove deprecated.zig autoFormatLabelFallback
- [ ] remove deprecated.zig autoFormatLabel
- [ ] remove deprecated.BufferedWriter and BufferedReader
- [ ] remove override_no_export_cpp_apis as it is no longer needed
- [ ] css Parser(W) -> Parser, and remove all the comptime writer: type
params
- [ ] remove deprecated writer fully

Files that add lines:

```
649     src/deprecated.zig
167     scripts/pack-codegen-for-zig-team.ts
54      scripts/cleartrace-impl.js
46      scripts/cleartrace.ts
43      src/windows.zig
18      src/fs.zig
17      src/bun.js/ConsoleObject.zig
16      src/output.zig
12      src/bun.js/test/debug.zig
12      src/bun.js/node/node_fs.zig
8       src/env_loader.zig
7       src/css/printer.zig
7       src/cli/init_command.zig
7       src/bun.js/node.zig
6       src/string/escapeRegExp.zig
6       src/install/PnpmMatcher.zig
5       src/bun.js/webcore/Blob.zig
4       src/crash_handler.zig
4       src/bun.zig
3       src/install/lockfile/bun.lock.zig
3       src/cli/update_interactive_command.zig
3       src/cli/pack_command.zig
3       build.zig
2       src/Progress.zig
2       src/install/lockfile/lockfile_json_stringify_for_debugging.zig
2       src/css/small_list.zig
2       src/bun.js/webcore/prompt.zig
1       test/internal/ban-words.test.ts
1       test/internal/ban-limits.json
1       src/watcher/WatcherTrace.zig
1       src/transpiler.zig
1       src/shell/builtin/cp.zig
1       src/js_printer.zig
1       src/io/PipeReader.zig
1       src/install/bin.zig
1       src/css/selectors/selector.zig
1       src/cli/run_command.zig
1       src/bun.js/RuntimeTranspilerStore.zig
1       src/bun.js/bindings/JSRef.zig
1       src/bake/DevServer.zig
```

Files that remove lines:

```
-1      src/test/recover.zig
-1      src/sql/postgres/SocketMonitor.zig
-1      src/sql/mysql/MySQLRequestQueue.zig
-1      src/sourcemap/CodeCoverage.zig
-1      src/css/values/color_js.zig
-1      src/compile_target.zig
-1      src/bundler/linker_context/convertStmtsForChunk.zig
-1      src/bundler/bundle_v2.zig
-1      src/bun.js/webcore/blob/read_file.zig
-1      src/ast/base.zig
-2      src/sql/postgres/protocol/ArrayList.zig
-2      src/shell/builtin/mkdir.zig
-2      src/install/PackageManager/patchPackage.zig
-2      src/install/PackageManager/PackageManagerDirectories.zig
-2      src/fmt.zig
-2      src/css/declaration.zig
-2      src/css/css_parser.zig
-2      src/collections/baby_list.zig
-2      src/bun.js/bindings/ZigStackFrame.zig
-2      src/ast/E.zig
-3      src/StandaloneModuleGraph.zig
-3      src/deps/picohttp.zig
-3      src/deps/libuv.zig
-3      src/btjs.zig
-4      src/threading/Futex.zig
-4      src/shell/builtin/touch.zig
-4      src/meta.zig
-4      src/install/lockfile.zig
-4      src/css/selectors/parser.zig
-5      src/shell/interpreter.zig
-5      src/css/error.zig
-5      src/bun.js/web_worker.zig
-5      src/bun.js.zig
-6      src/cli/test_command.zig
-6      src/bun.js/VirtualMachine.zig
-6      src/bun.js/uuid.zig
-6      src/bun.js/bindings/JSValue.zig
-9      src/bun.js/test/pretty_format.zig
-9      src/bun.js/api/BunObject.zig
-14     src/install/install_binding.zig
-14     src/fd.zig
-14     src/bun.js/node/path.zig
-14     scripts/pack-codegen-for-zig-team.sh
-17     src/bun.js/test/diff_format.zig
```

`git diff --numstat origin/main...HEAD | awk '{ print ($1-$2)"\t"$3 }' |
sort -rn`

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
Co-authored-by: Meghan Denny <meghan@bun.com>
Co-authored-by: tayor.fish <contact@taylor.fish>
This commit is contained in:
pfg
2025-11-10 14:38:26 -08:00
committed by GitHub
parent 143ad2ea58
commit 05d0475c6c
558 changed files with 6102 additions and 5212 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/sourcemap/CodeCoverage.zig
View File

@@ -65,7 +65,7 @@ pub const Report = struct {
vals: Fraction,
failing: Fraction,
failed: bool,
writer: anytype,
writer: *std.Io.Writer,
indent_name: bool,
comptime enable_colors: bool,
) !void {
@@ -82,7 +82,7 @@ pub const Report = struct {
}
try writer.writeAll(filename);
try writer.writeByteNTimes(' ', (max_filename_length - filename.len + @as(usize, @intFromBool(!indent_name))));
try writer.splatByteAll(' ', (max_filename_length - filename.len + @as(usize, @intFromBool(!indent_name))));
try writer.writeAll(comptime prettyFmt("<r><d> | <r>", enable_colors));
if (comptime enable_colors) {
@@ -121,7 +121,7 @@ pub const Report = struct {
max_filename_length: usize,
fraction: *Fraction,
base_path: []const u8,
writer: anytype,
writer: *std.Io.Writer,
comptime enable_colors: bool,
) !void {
const failing = fraction.*;
@@ -211,7 +211,7 @@ pub const Report = struct {
pub fn writeFormat(
report: *const Report,
base_path: []const u8,
writer: anytype,
writer: *std.Io.Writer,
) !void {
var filename = report.source_url.slice();
if (base_path.len > 0) {
@@ -282,7 +282,7 @@ pub const Report = struct {
usize,
usize,
bool,
) callconv(.C) void,
) callconv(.c) void,
) bool;
const Generator = struct {
@@ -296,7 +296,7 @@ pub const Report = struct {
blocks_len: usize,
function_start_offset: usize,
ignore_sourcemap: bool,
) callconv(.C) void {
) callconv(.c) void {
const blocks: []const BasicBlockRange = blocks_ptr[0..function_start_offset];
var function_blocks: []const BasicBlockRange = blocks_ptr[function_start_offset..blocks_len];
if (function_blocks.len > 1) {
@@ -371,7 +371,7 @@ pub const ByteRangeMapping = struct {
}
pub threadlocal var map: ?*HashMap = null;
pub fn generate(str: bun.String, source_contents_str: bun.String, source_id: i32) callconv(.C) void {
pub fn generate(str: bun.String, source_contents_str: bun.String, source_id: i32) callconv(.c) void {
var _map = map orelse brk: {
map = bun.handleOom(bun.jsc.VirtualMachine.get().allocator.create(HashMap));
map.?.* = HashMap.init(bun.jsc.VirtualMachine.get().allocator);
@@ -390,11 +390,11 @@ pub const ByteRangeMapping = struct {
entry.value_ptr.* = compute(source_contents.slice(), source_id, slice);
}
pub fn getSourceID(this: *ByteRangeMapping) callconv(.C) i32 {
pub fn getSourceID(this: *ByteRangeMapping) callconv(.c) i32 {
return this.source_id;
}
pub fn find(path: bun.String) callconv(.C) ?*ByteRangeMapping {
pub fn find(path: bun.String) callconv(.c) ?*ByteRangeMapping {
var slice = path.toUTF8(bun.default_allocator);
defer slice.deinit();
@@ -656,7 +656,7 @@ pub const ByteRangeMapping = struct {
blocks_len: usize,
function_start_offset: usize,
ignore_sourcemap: bool,
) callconv(.C) bun.jsc.JSValue {
) callconv(.c) bun.jsc.JSValue {
var this = ByteRangeMapping.find(source_url) orelse return bun.jsc.JSValue.null;
const blocks: []const BasicBlockRange = blocks_ptr[0..function_start_offset];
@@ -673,12 +673,11 @@ pub const ByteRangeMapping = struct {
var coverage_fraction = Fraction{};
var mutable_str = bun.MutableString.initEmpty(bun.default_allocator);
defer mutable_str.deinit();
var buffered_writer = mutable_str.bufferedWriter();
var writer = buffered_writer.writer();
var allocating_writer = std.Io.Writer.Allocating.init(bun.default_allocator);
defer allocating_writer.deinit();
const buffered_writer = &allocating_writer.writer;
Report.Text.writeFormat(&report, source_url.utf8ByteLength(), &coverage_fraction, "", &writer, false) catch {
Report.Text.writeFormat(&report, source_url.utf8ByteLength(), &coverage_fraction, "", buffered_writer, false) catch {
return globalThis.throwOutOfMemoryValue();
};
@@ -686,7 +685,7 @@ pub const ByteRangeMapping = struct {
return globalThis.throwOutOfMemoryValue();
};
return bun.String.createUTF8ForJS(globalThis, mutable_str.slice()) catch return .zero;
return bun.String.createUTF8ForJS(globalThis, allocating_writer.written()) catch return .zero;
}
pub fn compute(source_contents: []const u8, source_id: i32, source_url: bun.jsc.ZigString.Slice) ByteRangeMapping {