From 141c2b52b11034710e47caef86d9a644c8d0f296 Mon Sep 17 00:00:00 2001
From: Meghan Denny <hello@nektro.net>
Date: Fri, 1 Mar 2024 17:46:18 -0800
Subject: [PATCH] ci: fail step if actions/upload-artifact fails (#9194)

* ci: fail step if actions/upload-artifact fails

* the arm64 workflow doesnt have these and they were failing on x86
---
 .github/workflows/bun-linux-aarch64.yml    |  2 ++
 .github/workflows/bun-linux-build.yml      | 11 +++--------
 .github/workflows/bun-mac-aarch64.yml      |  5 +++++
 .github/workflows/bun-mac-x64-baseline.yml |  5 +++++
 .github/workflows/bun-mac-x64.yml          |  5 +++++
 .github/workflows/bun-windows.yml          |  6 ++++++
 packages/bun-uws/.github/workflows/cpp.yml |  1 +
 7 files changed, 27 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/bun-linux-aarch64.yml b/.github/workflows/bun-linux-aarch64.yml
index 7307f1590b..7869735648 100644
--- a/.github/workflows/bun-linux-aarch64.yml
+++ b/.github/workflows/bun-linux-aarch64.yml
@@ -117,10 +117,12 @@ jobs:
         with:
           name: bun-${{matrix.tag}}-profile
           path: ${{runner.temp}}/release/bun-${{matrix.tag}}-profile.zip
+          if-no-files-found: "error"
       - uses: actions/upload-artifact@v4
         with:
           name: bun-${{matrix.tag}}
           path: ${{runner.temp}}/release/bun-${{matrix.tag}}.zip
+          if-no-files-found: "error"
       - name: Release
         id: release
         uses: ncipollo/release-action@v1
diff --git a/.github/workflows/bun-linux-build.yml b/.github/workflows/bun-linux-build.yml
index 1876428adf..9cb00f793c 100644
--- a/.github/workflows/bun-linux-build.yml
+++ b/.github/workflows/bun-linux-build.yml
@@ -146,18 +146,12 @@ jobs:
         with:
           name: bun-${{matrix.tag}}-profile
           path: ${{runner.temp}}/release/bun-${{matrix.tag}}-profile.zip
+          if-no-files-found: "error"
       - uses: actions/upload-artifact@v4
         with:
           name: bun-${{matrix.tag}}
           path: ${{runner.temp}}/release/bun-${{matrix.tag}}.zip
-      - uses: actions/upload-artifact@v4
-        with:
-          name: bun-obj-${{matrix.tag}}
-          path: ${{runner.temp}}/release/bun-obj
-      - uses: actions/upload-artifact@v4
-        with:
-          name: ${{matrix.tag}}-dependencies
-          path: ${{runner.temp}}/release/bun-dependencies
+          if-no-files-found: "error"
       - name: Release
         id: release
         uses: ncipollo/release-action@v1
@@ -277,6 +271,7 @@ jobs:
         with:
           name: cores
           path: /cores
+          if-no-files-found: "error"
       - uses: sarisia/actions-status-discord@v1
         if: always() && steps.test.outputs.failing_tests != '' && github.event_name == 'pull_request'
         with:
diff --git a/.github/workflows/bun-mac-aarch64.yml b/.github/workflows/bun-mac-aarch64.yml
index 41e0a7274b..8aca751248 100644
--- a/.github/workflows/bun-mac-aarch64.yml
+++ b/.github/workflows/bun-mac-aarch64.yml
@@ -88,6 +88,7 @@ jobs:
         with:
           name: ${{ matrix.tag }}
           path: ${{runner.temp}}/release/bun-zig.o
+          if-no-files-found: "error"
 
   macOS-dependencies:
     name: macOS Dependencies
@@ -169,6 +170,7 @@ jobs:
         with:
           name: ${{ matrix.tag }}-deps
           path: ${{runner.temp}}/bun-deps
+          if-no-files-found: "error"
 
   macOS-cpp:
     name: macOS C++
@@ -239,6 +241,7 @@ jobs:
         with:
           name: ${{ matrix.tag }}-cpp
           path: ${{ runner.temp }}/bun-cpp-obj/bun-cpp-objects.a
+          if-no-files-found: "error"
   macOS-link:
     name: macOS Link
     runs-on: ${{ matrix.runner }}
@@ -334,10 +337,12 @@ jobs:
         with:
           name: ${{matrix.tag}}-profile
           path: ${{runner.temp}}/link-build/${{matrix.tag}}-profile.zip
+          if-no-files-found: "error"
       - uses: actions/upload-artifact@v4
         with:
           name: ${{matrix.tag}}
           path: ${{runner.temp}}/link-build/${{matrix.tag}}.zip
+          if-no-files-found: "error"
       - name: Release
         id: release
         uses: ncipollo/release-action@v1
diff --git a/.github/workflows/bun-mac-x64-baseline.yml b/.github/workflows/bun-mac-x64-baseline.yml
index 75a09f8881..051a40942b 100644
--- a/.github/workflows/bun-mac-x64-baseline.yml
+++ b/.github/workflows/bun-mac-x64-baseline.yml
@@ -79,6 +79,7 @@ jobs:
         with:
           name: ${{ matrix.tag }}
           path: ${{runner.temp}}/release/bun-zig.o
+          if-no-files-found: "error"
   macOS-dependencies:
     name: macOS Dependencies
     runs-on: ${{ matrix.runner }}
@@ -152,6 +153,7 @@ jobs:
         with:
           name: ${{ matrix.tag }}-deps
           path: ${{runner.temp}}/bun-deps
+          if-no-files-found: "error"
 
   macOS-cpp:
     name: macOS C++
@@ -222,6 +224,7 @@ jobs:
         with:
           name: ${{ matrix.tag }}-cpp
           path: ${{ runner.temp }}/bun-cpp-obj/bun-cpp-objects.a
+          if-no-files-found: "error"
   macOS:
     name: macOS Link
     runs-on: ${{ matrix.runner }}
@@ -313,10 +316,12 @@ jobs:
         with:
           name: ${{matrix.tag}}-profile
           path: ${{runner.temp}}/link-build/${{matrix.tag}}-profile.zip
+          if-no-files-found: "error"
       - uses: actions/upload-artifact@v4
         with:
           name: ${{matrix.tag}}
           path: ${{runner.temp}}/link-build/${{matrix.tag}}.zip
+          if-no-files-found: "error"
       - name: Release
         id: release
         uses: ncipollo/release-action@v1
diff --git a/.github/workflows/bun-mac-x64.yml b/.github/workflows/bun-mac-x64.yml
index 53551931b1..ddcc4ba990 100644
--- a/.github/workflows/bun-mac-x64.yml
+++ b/.github/workflows/bun-mac-x64.yml
@@ -76,6 +76,7 @@ jobs:
         with:
           name: ${{ matrix.tag }}
           path: ${{runner.temp}}/release/bun-zig.o
+          if-no-files-found: "error"
 
   macOS-dependencies:
     name: macOS Dependencies
@@ -150,6 +151,7 @@ jobs:
         with:
           name: ${{ matrix.tag }}-deps
           path: ${{runner.temp}}/bun-deps
+          if-no-files-found: "error"
 
   macOS-cpp:
     name: macOS C++
@@ -220,6 +222,7 @@ jobs:
         with:
           name: ${{ matrix.tag }}-cpp
           path: ${{ runner.temp }}/bun-cpp-obj/bun-cpp-objects.a
+          if-no-files-found: "error"
   macOS:
     name: macOS Link
     runs-on: ${{ matrix.runner }}
@@ -311,10 +314,12 @@ jobs:
         with:
           name: ${{matrix.tag}}-profile
           path: ${{runner.temp}}/link-build/${{matrix.tag}}-profile.zip
+          if-no-files-found: "error"
       - uses: actions/upload-artifact@v4
         with:
           name: ${{matrix.tag}}
           path: ${{runner.temp}}/link-build/${{matrix.tag}}.zip
+          if-no-files-found: "error"
       - name: Release
         id: release
         uses: ncipollo/release-action@v1
diff --git a/.github/workflows/bun-windows.yml b/.github/workflows/bun-windows.yml
index 84b1ac096a..725d8a9cfa 100644
--- a/.github/workflows/bun-windows.yml
+++ b/.github/workflows/bun-windows.yml
@@ -106,6 +106,7 @@ jobs:
         with:
           name: ${{ env.tag }}-${{ matrix.arch == 'x86_64' && 'x64' || 'aarch64' }}-zig${{ matrix.cpu == 'nehalem' && '-baseline' || '' }}
           path: ${{runner.temp}}/release/bun-zig.o
+          if-no-files-found: "error"
 
   windows-dependencies:
     name: Dependencies
@@ -169,6 +170,7 @@ jobs:
         with:
           name: ${{ env.tag }}-${{ matrix.arch == 'x86_64' && 'x64' || 'aarch64' }}-deps${{ matrix.cpu == 'nehalem' && '-baseline' || '' }}
           path: bun-deps/
+          if-no-files-found: "error"
 
       - name: Cache Dependencies
         if: ${{ !steps.cache-deps-restore.outputs.cache-hit }}
@@ -208,6 +210,7 @@ jobs:
         with:
           name: ${{ env.tag }}-${{ matrix.arch == 'x86_64' && 'x64' || 'aarch64' }}-codegen
           path: build-codegen-win32-x64/
+          if-no-files-found: "error"
 
   windows-cpp:
     name: C++ Build
@@ -267,6 +270,7 @@ jobs:
         with:
           name: ${{ env.tag }}-${{ matrix.arch == 'x86_64' && 'x64' || 'aarch64' }}-cpp${{ matrix.cpu == 'nehalem' && '-baseline' || '' }}
           path: build/bun-cpp-objects.a
+          if-no-files-found: "error"
 
   windows-link:
     strategy:
@@ -340,10 +344,12 @@ jobs:
         with:
           name: ${{ env.tag }}-${{ matrix.arch == 'x86_64' && 'x64' || 'aarch64' }}${{ matrix.cpu == 'nehalem' && '-baseline' || '' }}
           path: ${{ env.tag }}-${{ matrix.arch == 'x86_64' && 'x64' || 'aarch64' }}${{ matrix.cpu == 'nehalem' && '-baseline' || '' }}.zip
+          if-no-files-found: "error"
       - uses: actions/upload-artifact@v4
         with:
           name: ${{ env.tag }}-${{ matrix.arch == 'x86_64' && 'x64' || 'aarch64' }}${{ matrix.cpu == 'nehalem' && '-baseline' || '' }}-profile
           path: ${{ env.tag }}-${{ matrix.arch == 'x86_64' && 'x64' || 'aarch64' }}${{ matrix.cpu == 'nehalem' && '-baseline' || '' }}-profile.zip
+          if-no-files-found: "error"
       - name: Release
         id: release
         uses: ncipollo/release-action@v1
diff --git a/packages/bun-uws/.github/workflows/cpp.yml b/packages/bun-uws/.github/workflows/cpp.yml
index 44c68bb2e7..7b5943419f 100644
--- a/packages/bun-uws/.github/workflows/cpp.yml
+++ b/packages/bun-uws/.github/workflows/cpp.yml
@@ -25,6 +25,7 @@ jobs:
       with:
         name: artifacts
         path: ./out/artifacts
+        if-no-files-found: "error"
 
   build_windows:
     runs-on: windows-latest