From 1fc86391775bfd0b267d958bbbf2f7ce5e4d6952 Mon Sep 17 00:00:00 2001 From: Ashcon Partovi Date: Mon, 1 May 2023 08:48:27 -0700 Subject: [PATCH] Condense errors in test runner script --- .github/scripts/test-runner.ts | 8 +++++--- .github/workflows/bun-test.yml | 7 ++++--- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/.github/scripts/test-runner.ts b/.github/scripts/test-runner.ts index a21cc818d4..946e2315b3 100644 --- a/.github/scripts/test-runner.ts +++ b/.github/scripts/test-runner.ts @@ -558,15 +558,17 @@ function formatTest(result: ParseTestResult, options?: FormatTestOptions): strin .filter(({ status }) => status === "fail") .map(({ name, errors }) => { let content = header(3, name); + let hasLink = false; if (errors) { content += errors .map(({ name, message, stack }) => { let preview = code(`${name}: ${message}`, "diff"); if (stack?.length && baseUrl) { const { file, line } = stack[0]; - if (!is3rdParty(file)) { - const { href } = new URL(`${file}?plain=1#L${Math.max(1, line - 5)}-L${line}`, baseUrl); - preview += `\n${href}\n`; + if (!is3rdParty(file) && !hasLink) { + const { href } = new URL(`${file}?plain=1#L${line}`, baseUrl); + content = link(content, href); + hasLink = true; } } return preview; diff --git a/.github/workflows/bun-test.yml b/.github/workflows/bun-test.yml index 60c25c9931..af5b4bcc3f 100644 --- a/.github/workflows/bun-test.yml +++ b/.github/workflows/bun-test.yml @@ -33,9 +33,10 @@ jobs: - os: ubuntu-latest tag: linux-x64-baseline url: linux/x64?baseline=true - - os: macos-latest - tag: darwin-x64 - url: darwin/x64?avx2=true + # FIXME: runner fails with "No tests found"? + #- os: macos-latest + # tag: darwin-x64 + # url: darwin/x64?avx2=true - os: macos-latest tag: darwin-x64-baseline url: darwin/x64?baseline=true