mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-16 13:51:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

cpp: audit redundant and problematic uses of JSValue constructor (#20623)

Browse Source
This commit is contained in:
Meghan Denny
2025-06-24 19:58:44 -08:00
committed by GitHub
parent 61024b2b4a
commit 2072fa1d59
49 changed files with 266 additions and 304 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/bun.js/bindings/ModuleLoader.cpp
View File

@@ -1029,7 +1029,7 @@ static JSValue fetchESMSourceCode(
else if (res->result.value.tag == SyntheticModuleType::ExportsObject) {
JSC::JSValue value = JSC::JSValue::decode(res->result.value.jsvalue_for_export);
if (!value) {
return reject(JSC::JSValue(JSC::createSyntaxError(globalObject, "Failed to parse Object"_s)));
return reject(JSC::createSyntaxError(globalObject, "Failed to parse Object"_s));
}
// JSON can become strings, null, numbers, booleans so we must handle "export default 123"
@@ -1044,7 +1044,7 @@ static JSValue fetchESMSourceCode(
} else if (res->result.value.tag == SyntheticModuleType::ExportDefaultObject) {
JSC::JSValue value = JSC::JSValue::decode(res->result.value.jsvalue_for_export);
if (!value) {
return reject(JSC::JSValue(JSC::createSyntaxError(globalObject, "Failed to parse Object"_s)));
return reject(JSC::createSyntaxError(globalObject, "Failed to parse Object"_s));
}
// JSON can become strings, null, numbers, booleans so we must handle "export default 123"