mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-02 15:08:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add crash pattern rules for duplicate issue detection (#23658)

Browse Source
This commit is contained in:
robobun
2025-10-14 10:14:52 -07:00
committed by GitHub
parent bd88717ddc
commit 25d23201b6
2 changed files with 48 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/labeled.yml vendored
View File

@@ -142,7 +142,7 @@ jobs:
uses: actions/github-script@v7
with:
script: |
const closeAction = JSON.parse('${{ steps.add-labels.outputs.close-action }}');
const closeAction = ${{ fromJson(steps.add-labels.outputs.close-action) }};
// Comment with the reason
await github.rest.issues.createComment({

51
scripts/handle-crash-patterns.ts
View File

@@ -15,8 +15,11 @@ interface CloseAction {
let closeAction: CloseAction | null = null;
// Compute lowercase once for performance
const bodyLower = body.toLowerCase();
// Check for workers_terminated
if (body.includes("workers_terminated")) {
if (bodyLower.includes("workers_terminated")) {
closeAction = {
reason: "not_planned",
comment: `Duplicate of #15964
@@ -25,7 +28,10 @@ We are tracking worker stability issues in https://github.com/oven-sh/bun/issues
}
// Check for better-sqlite3 with RunCommand or AutoCommand
else if (body.includes("better-sqlite3") && (body.includes("[RunCommand]") || body.includes("[AutoCommand]"))) {
else if (
bodyLower.includes("better-sqlite3") &&
(bodyLower.includes("runcommand") || bodyLower.includes("autocommand"))
) {
closeAction = {
reason: "not_planned",
comment: `Duplicate of #4290.
@@ -33,12 +39,45 @@ better-sqlite3 is not supported yet in Bun due to missing V8 C++ APIs. For now,
};
}
// Check for ENOTCONN with Transport and standalone_executable on v1.2.23
else if (
bodyLower.includes("enotconn") &&
bodyLower.includes("transport") &&
bodyLower.includes("standalone_executable") &&
/\bv?1\.2\.23\b/i.test(bodyLower)
) {
closeAction = {
reason: "completed",
comment: `Duplicate of #23342.
This issue was fixed in Bun v1.3. Please upgrade to the latest version:
\`\`\`sh
bun upgrade
\`\`\``,
};
}
// Check for WASM IPInt 32 stack traces - be very specific to avoid false positives
else if (bodyLower.includes("wasm_trampoline_wasm_ipint_call_wide32")) {
closeAction = {
reason: "not_planned",
comment: `Duplicate of #17841.
This is a known issue with JavaScriptCore's WASM In-place interpreter on Linux x64. You can work around it by:
1. Setting \`BUN_JSC_useWasmIPInt=0\` to disable IPInt (reverts to older Wasm interpreter)
2. Using an aarch64 CPU instead of x86_64
3. Using \`BUN_JSC_jitPolicyScale=0\` to force JIT compilation (may impact startup performance)
We've reported this to WebKit and are tracking the issue in #17841.`,
};
}
// Check for CPU architecture issues (Segmentation Fault/Illegal Instruction with no_avx)
else if (
(body.includes("Segmentation Fault") ||
body.includes("Illegal Instruction") ||
body.includes("IllegalInstruction")) &&
body.includes("no_avx")
(bodyLower.includes("segmentation fault") ||
bodyLower.includes("illegal instruction") ||
bodyLower.includes("illegalinstruction")) &&
bodyLower.includes("no_avx")
) {
let comment = `Bun requires a CPU with the micro-architecture [\`nehalem\`](https://en.wikipedia.org/wiki/Nehalem_(microarchitecture)) or later (released in 2008). If you're using a CPU emulator like qemu, then try enabling x86-64-v2.`;