From 2ffcccc5b48b0b39e807ec55474508aba8d55d03 Mon Sep 17 00:00:00 2001 From: Jarred Sumner Date: Mon, 26 Aug 2024 16:09:48 -0700 Subject: [PATCH] Fixes #5591 (#13541) --- src/js/node/net.ts | 2 ++ test/js/node/net/node-net.test.ts | 7 ++++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/js/node/net.ts b/src/js/node/net.ts index f8c770f020..6711079154 100644 --- a/src/js/node/net.ts +++ b/src/js/node/net.ts @@ -1202,4 +1202,6 @@ export default { setDefaultAutoSelectFamilyAttemptTimeout: $zig("node_net_binding.zig", "setDefaultAutoSelectFamilyAttemptTimeout"), BlockList, + // https://github.com/nodejs/node/blob/2eff28fb7a93d3f672f80b582f664a7c701569fb/lib/net.js#L2456 + Stream: Socket, }; diff --git a/test/js/node/net/node-net.test.ts b/test/js/node/net/node-net.test.ts index f7cf81dcc3..ee5f312154 100644 --- a/test/js/node/net/node-net.test.ts +++ b/test/js/node/net/node-net.test.ts @@ -1,11 +1,16 @@ import { ServerWebSocket, TCPSocket, Socket as _BunSocket, TCPSocketListener } from "bun"; import { describe, expect, it } from "bun:test"; -import { connect, isIP, isIPv4, isIPv6, Socket, createConnection, Server } from "net"; +import { Stream, connect, isIP, isIPv4, isIPv6, Socket, createConnection, Server } from "net"; import { join } from "path"; import { bunEnv, bunExe, tmpdirSync } from "harness"; const socket_domain = tmpdirSync(); +it("Stream should be aliased to Socket", () => { + // https://github.com/nodejs/node/blob/2eff28fb7a93d3f672f80b582f664a7c701569fb/lib/net.js#L2456 + expect(Socket).toBe(Stream); +}); + it("should support net.isIP()", () => { expect(isIP("::1")).toBe(6); expect(isIP("foobar")).toBe(0);