From 3674493aa4cd0b416f79765a24f9badd123a45cd Mon Sep 17 00:00:00 2001
From: Ashcon Partovi <ashcon@partovi.net>
Date: Mon, 5 Aug 2024 17:49:12 -0700
Subject: [PATCH] Potential fix for canary artifacts missing

---
 .buildkite/scripts/upload-release.sh | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/.buildkite/scripts/upload-release.sh b/.buildkite/scripts/upload-release.sh
index 7ca5d7725a..c3328cb9c2 100755
--- a/.buildkite/scripts/upload-release.sh
+++ b/.buildkite/scripts/upload-release.sh
@@ -146,6 +146,7 @@ function update_github_release() {
   local version="$1"
   local tag="$(release_tag "$version")"
   if [ "$tag" == "canary" ]; then
+    sleep 5 # There is possibly a race condition where this overwrites artifacts?
     run_command gh release edit "$tag" --repo "$BUILDKITE_REPO" \
       --notes "This release of Bun corresponds to the commit: $BUILDKITE_COMMIT"
   fi
@@ -188,12 +189,12 @@ function create_release() {
     upload_s3_file "releases/$BUILDKITE_COMMIT" "$artifact" &
     upload_s3_file "releases/$tag" "$artifact" &
     upload_github_asset "$tag" "$artifact" &
+    wait
   }
 
   for artifact in "${artifacts[@]}"; do
-    upload_artifact "$artifact" &
+    upload_artifact "$artifact"
   done
-  wait
 
   update_github_release "$tag"
   create_sentry_release "$tag"