From 38901d79cb545a65beb78e1dbf3f8d63ae77db9c Mon Sep 17 00:00:00 2001 From: Ciro Spaciari Date: Wed, 23 Apr 2025 19:21:39 -0700 Subject: [PATCH] de-flaky --- test/js/node/http/node-http.test.ts | 42 ++++++++++++----------------- 1 file changed, 17 insertions(+), 25 deletions(-) diff --git a/test/js/node/http/node-http.test.ts b/test/js/node/http/node-http.test.ts index 22cf72a644..693fa89213 100644 --- a/test/js/node/http/node-http.test.ts +++ b/test/js/node/http/node-http.test.ts @@ -2421,45 +2421,37 @@ it("should reject non-standard body writes when rejectNonStandardBodyWrites is t test("request.socket._secureEstablished should identify if the request is secure", async () => { { - const { promise, resolve, reject } = Promise.withResolvers(); - const server = createHttpsServer(COMMON_TLS_CERT, (request, response) => { + let _secureEstablished; + await using server = createHttpsServer(COMMON_TLS_CERT, (request, response) => { // Run the check function - expect(request.socket._secureEstablished).toBe(true); + _secureEstablished = request.socket._secureEstablished; response.writeHead(200, {}); response.end("ok"); - server.close(); - resolve(); }); - server.listen(0, () => { - const port = server.address().port; - fetch(`https://localhost:${port}`, { - tls: { - ca: COMMON_TLS_CERT.cert, - }, - }).catch(reject); + await once(server.listen(0), "listening"); + const port = server.address().port; + await fetch(`https://localhost:${port}`, { + tls: { + ca: COMMON_TLS_CERT.cert, + }, }); - - await promise; + expect(_secureEstablished).toBe(true); } { - const { promise, resolve, reject } = Promise.withResolvers(); - const server = createServer((request, response) => { + let _secureEstablished; + await using server = createServer((request, response) => { // Run the check function - expect(request.socket._secureEstablished).toBe(false); + _secureEstablished = request.socket._secureEstablished; response.writeHead(200, {}); response.end("ok"); - server.close(); - resolve(); }); - server.listen(0, () => { - const port = server.address().port; - fetch(`http://localhost:${port}`).catch(reject); - }); - - await promise; + await once(server.listen(0), "listening"); + const port = server.address().port; + await fetch(`http://localhost:${port}`); + expect(_secureEstablished).toBe(false); } });