diff --git a/src/js/internal/sql/mysql.ts b/src/js/internal/sql/mysql.ts index 2ec1c0d8e7..8e4702944e 100644 --- a/src/js/internal/sql/mysql.ts +++ b/src/js/internal/sql/mysql.ts @@ -396,19 +396,15 @@ class PooledMySQLConnection { this.queryCount = 0; this.flags &= ~PooledConnectionFlags.reserved; - try { - // notify all queries that the connection is closed - for (const onClose of queries) { - onClose(err); - } - const onFinish = this.onFinish; - if (onFinish) { - onFinish(err); - } - } catch (e) { - console.log("onClose error", e, this instanceof PooledMySQLConnection, this); - throw e; + // notify all queries that the connection is closed + for (const onClose of queries) { + onClose(err); } + const onFinish = this.onFinish; + if (onFinish) { + onFinish(err); + } + this.adapter.release(this, true); } diff --git a/src/sql/mysql/protocol/ErrorPacket.zig b/src/sql/mysql/protocol/ErrorPacket.zig index 5e16c7c97f..6fb6ef9b37 100644 --- a/src/sql/mysql/protocol/ErrorPacket.zig +++ b/src/sql/mysql/protocol/ErrorPacket.zig @@ -19,7 +19,7 @@ pub fn createMySQLError( message: []const u8, options: MySQLErrorOptions, ) bun.JSError!JSValue { - const opts_obj = JSValue.createEmptyObject(globalObject, 18); + const opts_obj = JSValue.createEmptyObject(globalObject, 0); opts_obj.ensureStillAlive(); opts_obj.put(globalObject, JSC.ZigString.static("code"), try bun.String.createUTF8ForJS(globalObject, options.code)); if (options.errno) |errno| {