From 3cb462a3e69811dd34200d0eaaba89471e44d82a Mon Sep 17 00:00:00 2001 From: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com> Date: Wed, 30 Nov 2022 07:28:48 -0800 Subject: [PATCH] Fix console.log regression with emoji --- src/bun.js/bindings/exports.zig | 4 ++-- test/bun.js/inspect.test.js | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/bun.js/bindings/exports.zig b/src/bun.js/bindings/exports.zig index 2387122dd8..4f98e93055 100644 --- a/src/bun.js/bindings/exports.zig +++ b/src/bun.js/bindings/exports.zig @@ -1485,7 +1485,7 @@ pub const ZigConsoleClient = struct { if (!any_non_ascii) writer.writeAll(end) else - writer.writeLatin1(end); + writer.writeAll(end); any_non_ascii = false; slice = slice[@minimum(slice.len, i + 1)..]; i = 0; @@ -1518,7 +1518,7 @@ pub const ZigConsoleClient = struct { } } - if (slice.len > 0) writer.writeLatin1(slice); + if (slice.len > 0) writer.writeAll(slice); } pub fn WrappedWriter(comptime Writer: type) type { diff --git a/test/bun.js/inspect.test.js b/test/bun.js/inspect.test.js index 5dc0bc645a..67e19e9853 100644 --- a/test/bun.js/inspect.test.js +++ b/test/bun.js/inspect.test.js @@ -321,3 +321,7 @@ describe("crash testing", () => { }); } }); + +it("possibly formatted emojis log", () => { + expect(Bun.inspect("✔", "hey")).toBe("✔ hey"); +});