mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-20 07:42:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Micro-optimize Module._resolveFilename (#13322)

Browse Source
This commit is contained in:
Jarred Sumner
2024-08-14 23:36:46 -07:00
committed by GitHub
parent 36fc324523
commit 3f686222d4
5 changed files with 21 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/bun.js/modules/NodeModuleModule.h
View File

@@ -267,7 +267,7 @@ JSC_DEFINE_HOST_FUNCTION(jsFunctionResolveFileName, (JSC::JSGlobalObject * globa
// weird thing.
(fromValue.isObject()) {
if (auto idValue = fromValue.getObject()->getIfPropertyExists(globalObject, Identifier::fromString(vm, "filename"_s))) {
if (auto idValue = fromValue.getObject()->getIfPropertyExists(globalObject, builtinNames(vm).filenamePublicName())) {
if (idValue.isString()) {
fromValue = idValue;
}
@@ -334,21 +334,25 @@ struct Parent {
Parent getParent(VM&vm, JSGlobalObject* global, JSValue maybe_parent) {
Parent value { nullptr, nullptr };
if (!maybe_parent.isCell()) {
return value;
}
if (!maybe_parent.isObject()) {
if (!maybe_parent) {
return value;
}
auto parent = maybe_parent.getObject();
if (!parent) {
return value;
}
auto scope = DECLARE_THROW_SCOPE(vm);
JSValue paths = parent->get(global, Identifier::fromString(vm, "paths"_s));
const auto& builtinNames = Bun::builtinNames(vm);
JSValue paths = parent->get(global, builtinNames.pathsPublicName());
RETURN_IF_EXCEPTION(scope, value);
if (paths.isCell()) {
value.paths = jsDynamicCast<JSArray*>(paths);
}
JSValue filename = parent->get(global, Identifier::fromString(vm, "filename"_s));
JSValue filename = parent->get(global, builtinNames.filenamePublicName());
RETURN_IF_EXCEPTION(scope, value);
if (filename.isString()) {
value.filename = filename.toString(global);
@@ -517,7 +521,7 @@ DEFINE_NATIVE_MODULE(NodeModule) {
putNativeFn(Identifier::fromString(vm, "_resolveLookupPaths"_s), jsFunctionResolveLookupPaths);
putNativeFn(Identifier::fromString(vm, "createRequire"_s), jsFunctionNodeModuleCreateRequire);
putNativeFn(Identifier::fromString(vm, "paths"_s), Resolver__nodeModulePathsForJS);
putNativeFn(builtinNames(vm).pathsPublicName(), Resolver__nodeModulePathsForJS);
putNativeFn(Identifier::fromString(vm, "findSourceMap"_s), jsFunctionFindSourceMap);
putNativeFn(Identifier::fromString(vm, "syncBuiltinExports"_s), jsFunctionSyncBuiltinExports);
putNativeFn(Identifier::fromString(vm, "SourceMap"_s), jsFunctionSourceMap);