From 45bd2264e370db7a7b93e5d2b6207257f444be68 Mon Sep 17 00:00:00 2001 From: Meghan Denny Date: Fri, 12 Jan 2024 18:17:53 -0800 Subject: [PATCH] more small undefined fixes (#8133) --- src/__global.zig | 2 +- src/bit_set.zig | 4 ++-- src/bun.js/uuid.zig | 2 +- src/bun_js.zig | 3 ++- src/bundler.zig | 4 ++-- src/http.zig | 2 +- src/logger.zig | 2 +- src/multi_array_list.zig | 2 +- src/sha.zig | 4 +--- 9 files changed, 12 insertions(+), 13 deletions(-) diff --git a/src/__global.zig b/src/__global.zig index fc1906231c..fcb03d76d7 100644 --- a/src/__global.zig +++ b/src/__global.zig @@ -188,7 +188,7 @@ const string = @import("root").bun.string; pub const BunInfo = struct { bun_version: string, - platform: Analytics.GenerateHeader.GeneratePlatform.Platform = undefined, + platform: Analytics.GenerateHeader.GeneratePlatform.Platform, framework: string = "", framework_version: string = "", diff --git a/src/bit_set.zig b/src/bit_set.zig index 58e59233a8..4b5f9c23f4 100644 --- a/src/bit_set.zig +++ b/src/bit_set.zig @@ -460,7 +460,7 @@ pub fn ArrayBitSet(comptime MaskIntType: type, comptime size: usize) type { mask2 = std.math.boolMask(MaskInt, value) >> (mask_len - 1) - (end_bit - 1); self.masks[start_mask_index] |= mask1 & mask2; } else { - var bulk_mask_index: usize = undefined; + var bulk_mask_index: usize = 0; if (start_bit > 0) { self.masks[start_mask_index] = (self.masks[start_mask_index] & ~(std.math.boolMask(MaskInt, true) << start_bit)) | @@ -913,7 +913,7 @@ pub const DynamicBitSetUnmanaged = struct { mask2 = std.math.boolMask(MaskInt, value) >> (@bitSizeOf(MaskInt) - 1) - (end_bit - 1); self.masks[start_mask_index] |= mask1 & mask2; } else { - var bulk_mask_index: usize = undefined; + var bulk_mask_index: usize = 0; if (start_bit > 0) { self.masks[start_mask_index] = (self.masks[start_mask_index] & ~(std.math.boolMask(MaskInt, true) << start_bit)) | diff --git a/src/bun.js/uuid.zig b/src/bun.js/uuid.zig index e38ed567f6..045195d0ad 100644 --- a/src/bun.js/uuid.zig +++ b/src/bun.js/uuid.zig @@ -8,7 +8,7 @@ const bun = @import("root").bun; pub const Error = error{InvalidUUID}; const UUID = @This(); -bytes: [16]u8 = undefined, +bytes: [16]u8, pub fn init() UUID { var uuid = UUID{ .bytes = undefined }; diff --git a/src/bun_js.zig b/src/bun_js.zig index 6ee2f7d01d..353492c144 100644 --- a/src/bun_js.zig +++ b/src/bun_js.zig @@ -39,7 +39,7 @@ pub const Run = struct { ctx: Command.Context, vm: *VirtualMachine, entry_path: string, - arena: Arena = undefined, + arena: Arena, any_unhandled: bool = false, pub fn bootStandalone(ctx_: Command.Context, entry_path: string, graph: bun.StandaloneModuleGraph) !void { @@ -375,6 +375,7 @@ pub const Run = struct { vm.onUnhandledError(this.vm.global, this.vm.pending_internal_promise.result(vm.global.vm())); } } else { + // while (vm.isEventLoopAlive()) { vm.tick(); vm.eventLoop().autoTickActive(); diff --git a/src/bundler.zig b/src/bundler.zig index 1f50d74335..9ca0a2d40b 100644 --- a/src/bundler.zig +++ b/src/bundler.zig @@ -311,7 +311,7 @@ pub const Bundler = struct { options: options.BundleOptions, log: *logger.Log, allocator: std.mem.Allocator, - result: options.TransformResult = undefined, + result: options.TransformResult, resolver: Resolver, fs: *Fs.FileSystem, output_files: std.ArrayList(options.OutputFile), @@ -323,7 +323,7 @@ pub const Bundler = struct { source_map: options.SourceMapOption = .none, linker: Linker, - timer: SystemTimer = undefined, + timer: SystemTimer, env: *DotEnv.Loader, macro_context: ?js_ast.Macro.MacroContext = null, diff --git a/src/http.zig b/src/http.zig index 0a96dfbe8b..05c0e67caa 100644 --- a/src/http.zig +++ b/src/http.zig @@ -705,7 +705,7 @@ pub const HTTPThread = struct { queued_tasks: Queue = Queue{}, queued_shutdowns: ShutdownQueue = ShutdownQueue{}, has_awoken: std.atomic.Value(bool) = std.atomic.Value(bool).init(false), - timer: std.time.Timer = undefined, + timer: std.time.Timer, const threadlog = Output.scoped(.HTTPThread, true); const FakeStruct = struct { diff --git a/src/logger.zig b/src/logger.zig index c6707f6a4a..5a5ccbe905 100644 --- a/src/logger.zig +++ b/src/logger.zig @@ -1393,7 +1393,7 @@ pub const Source = struct { if (quote == '"' or quote == '\'') { var i: usize = 1; - var c: u8 = undefined; + var c: u8 = 0; while (i < text.len) { c = text[i]; diff --git a/src/multi_array_list.zig b/src/multi_array_list.zig index 7fac062a2d..3cf9573a92 100644 --- a/src/multi_array_list.zig +++ b/src/multi_array_list.zig @@ -906,7 +906,7 @@ test "sorting a span" { } }{ .chars = sliced.items(.chr) }); - var i: u32 = undefined; + var i: u32 = 0; var j: u32 = 6; var c: u8 = 'a'; diff --git a/src/sha.zig b/src/sha.zig index 014e550252..0d59abbc14 100644 --- a/src/sha.zig +++ b/src/sha.zig @@ -50,9 +50,7 @@ fn NewEVP( BoringSSL.load(); const md = @call(.auto, @field(BoringSSL, MDName), .{}); - var this: @This() = .{ - .ctx = undefined, - }; + var this = @This(){}; BoringSSL.EVP_MD_CTX_init(&this.ctx);