mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-12 20:09:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

More comments

Browse Source
This commit is contained in:
Jarred Sumner
2023-05-30 00:30:47 -07:00
parent 85565d95d5
commit 481f916f3f
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/bun.js/bindings/CommonJSModuleRecord.cpp
View File

@@ -351,6 +351,7 @@ JSC::SourceCode createCommonJSModule(
false, false, EvalContextType::None, nullptr, nullptr, ECMAMode::sloppy());
if (UNLIKELY(!executable && !throwScope.exception())) {
// I'm not sure if this case happens, but it's better to be safe than sorry.
throwSyntaxError(globalObject, throwScope, "Failed to compile CommonJS module."_s);
}
@@ -380,6 +381,13 @@ JSC::SourceCode createCommonJSModule(
JSValue result = moduleObject->exportsObject();
// The developer can do something like:
//
// Object.defineProperty(module, 'exports', {get: getter})
//
// In which case, the exports object is now a GetterSetter object.
//
// We can't return a GetterSetter object to ESM code, so we need to call it.
if (!result.isEmpty() && (result.isGetterSetter() || result.isCustomGetterSetter())) {
auto* clientData = WebCore::clientData(vm);