From 483ccc63d557576ba55167733abbf489a03d6363 Mon Sep 17 00:00:00 2001 From: Claude Bot Date: Sat, 31 Jan 2026 18:29:37 +0000 Subject: [PATCH] Address additional review comments - Change catch parameter from `e: any` to `e: unknown` with safe error message extraction - Log install stdout/stderr on failure for easier debugging Co-Authored-By: Claude Opus 4.5 --- test/regression/issue/26638.test.ts | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/test/regression/issue/26638.test.ts b/test/regression/issue/26638.test.ts index 188910494f..d0c67b3a62 100644 --- a/test/regression/issue/26638.test.ts +++ b/test/regression/issue/26638.test.ts @@ -126,8 +126,16 @@ req.end(); }), { headers: { "Content-Type": "application/json" } }, ); - } catch (e: any) { - return new Response(JSON.stringify({ success: false, error: e.message }), { + } catch (e: unknown) { + let errorMessage: string; + if (e instanceof Error) { + errorMessage = e.message; + } else if (typeof e === "object" && e !== null && "message" in e) { + errorMessage = String((e as { message: unknown }).message); + } else { + errorMessage = String(e); + } + return new Response(JSON.stringify({ success: false, error: errorMessage }), { status: 500, headers: { "Content-Type": "application/json" }, }); @@ -176,7 +184,15 @@ upload(); stdout: "pipe", stderr: "pipe", }); - const installExitCode = await installProc.exited; + const [installStdout, installStderr, installExitCode] = await Promise.all([ + installProc.stdout.text(), + installProc.stderr.text(), + installProc.exited, + ]); + if (installExitCode !== 0) { + console.error("Install stdout:", installStdout); + console.error("Install stderr:", installStderr); + } expect(installExitCode).toBe(0); // Run the client