mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-11 19:38:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix assertions_only usage in fromJSHostCallGeneric (#20733)

Browse Source
This commit is contained in:
190n
2025-07-01 23:36:56 -07:00
committed by GitHub
parent e1ec32caea
commit 48c5256196
14 changed files with 219 additions and 168 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/string.zig
View File

@@ -514,15 +514,15 @@ pub const String = extern struct {
}
pub fn fromJS(value: bun.JSC.JSValue, globalObject: *JSC.JSGlobalObject) bun.JSError!String {
var scope: JSC.CatchScope = undefined;
scope.init(globalObject, @src(), .assertions_only);
var scope: JSC.ExceptionValidationScope = undefined;
scope.init(globalObject, @src());
defer scope.deinit();
var out: String = String.dead;
const ok = BunString__fromJS(globalObject, value, &out);
// If there is a pending exception, but stringifying succeeds, we don't return JSError.
// We do need to always call hasException() to satisfy the need for an exception check.
const has_exception = scope.hasException();
const has_exception = scope.hasExceptionOrFalseWhenAssertionsAreDisabled();
if (ok) {
bun.debugAssert(out.tag != .Dead);
} else {