From 4e8252da9d550388d49ceed812d0114657ad5fdf Mon Sep 17 00:00:00 2001 From: RiskyMH Date: Fri, 13 Jun 2025 18:40:39 +1000 Subject: [PATCH] oops --- src/cli/upgrade_command.zig | 10 ++++++---- test/cli/install/bun-upgrade.test.ts | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/cli/upgrade_command.zig b/src/cli/upgrade_command.zig index c8204089a9..8de0aa81b1 100644 --- a/src/cli/upgrade_command.zig +++ b/src/cli/upgrade_command.zig @@ -350,14 +350,16 @@ pub const UpgradeCommand = struct { if (args.len > 2) { var upgrade_index: ?usize = null; for (args[1..], 1..) |arg, i| { - if (upgrade_index == null and strings.eqlComptime(arg, "upgrade")) { - upgrade_index = i + 1; - continue; + if (upgrade_index) |_| { + if (strings.eqlComptime(arg, "upgrade")) { + upgrade_index = i + 1; + continue; + } } // if this is before the "upgrade", just judge that it's a flag (because BUN_OPTIONS are passed here) // otherwise, needs to be one of the specific flags - if (upgrade_index == null) { + if (upgrade_index) |_| { if (strings.startsWith(arg, "--")) continue; } else { if (strings.eqlComptime(arg, "--canary") or diff --git a/test/cli/install/bun-upgrade.test.ts b/test/cli/install/bun-upgrade.test.ts index e76a0e0549..aa5601429b 100644 --- a/test/cli/install/bun-upgrade.test.ts +++ b/test/cli/install/bun-upgrade.test.ts @@ -43,7 +43,7 @@ const invalid_tests = [ [["upgrade", "--latest"], "bun update --latest"], ]; for (const [args, expected] of invalid_tests) { - it("two invalid arguments, should display error message and suggest command", async () => { + it(`"${args.join(" ")}": should display error message and suggest command`, async () => { const { stderr } = spawn({ cmd: [execPath, ...args], cwd,