mirror of
https://github.com/oven-sh/bun
synced 2026-02-10 02:48:50 +00:00
fix: correct logic bugs in libarchive, s3 credentials, and postgres bindings (#25905)
## Summary - **libarchive.zig:110**: Fix self-assignment bug where `this.pos` was assigned to itself instead of `new_pos` - **s3/credentials.zig:165,176,199**: Fix impossible range checks - `and` should be `or` for pageSize, partSize, and retry validation (a value cannot be both less than MIN and greater than MAX simultaneously) - **postgres.zig:14**: Fix copy-paste error where createConnection function was internally named "createQuery" ## Test plan - [ ] Verify S3 credential validation now properly rejects out-of-range values for pageSize, partSize, and retry - [ ] Verify libarchive seek operations work correctly - [ ] Verify postgres createConnection function has correct internal name 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Jarred Sumner <jarred@jarredsumner.com> Co-authored-by: Claude Bot <claude-bot@bun.sh>
This commit is contained in:
@@ -11,7 +11,7 @@ pub fn createBinding(globalObject: *jsc.JSGlobalObject) JSValue {
|
||||
binding.put(
|
||||
globalObject,
|
||||
ZigString.static("createConnection"),
|
||||
jsc.JSFunction.create(globalObject, "createQuery", PostgresSQLConnection.call, 2, .{}),
|
||||
jsc.JSFunction.create(globalObject, "createConnection", PostgresSQLConnection.call, 2, .{}),
|
||||
);
|
||||
|
||||
return binding;
|
||||
|
||||
Reference in New Issue
Block a user