mirror of
https://github.com/oven-sh/bun
synced 2026-02-02 15:08:46 +00:00
test: refactor bundler_promiseall_deadcode to use itBundled helper (#23370)
## Summary Modernizes `test/bundler/bundler_promiseall_deadcode.test.ts` to use the `itBundled` test helper instead of manual temp directory creation and spawning. This makes the test more concise, maintainable, and consistent with other bundler tests. ## Changes - Replace `tempDirWithFiles` + manual `Bun.spawn` with `itBundled` - Use `files` object for test fixtures instead of creating a temp directory - Use `onAfterBundle` callback for bundled output assertions - Use `run.validate` for runtime stderr validation - Use `run.partialStdout` for stdout verification - Preserve all original test assertions and behavior ## Test Results All 3 tests pass with identical functional behavior: ``` 3 pass 0 fail 2 snapshots, 23 expect() calls Ran 3 tests across 1 file. [8.95s] ``` ## Verification All original assertions are preserved: - ✅ Build success validation - ✅ Bundled output snapshots (updated paths to match itBundled format) - ✅ `__esm` and `__promiseAll` presence/absence checks - ✅ Runtime execution validation (exit code 0) - ✅ Runtime stderr validation (no async syntax errors) - ✅ Runtime stdout validation (contains expected output) The test is now more concise (407 insertions vs 514 deletions) while maintaining full test coverage. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Bot <claude-bot@bun.sh> Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
robobun
@@ -1,530 +1,423 @@
|
||||
import { expect, test } from "bun:test";
|
||||
import { bunEnv, bunExe, tempDirWithFiles } from "harness";
|
||||
import { join } from "path";
|
||||
import { describe, expect } from "bun:test";
|
||||
import { itBundled } from "./expectBundled";
|
||||
|
||||
test("__promiseAll is tree-shaken when only one async import exists but __esm remains", async () => {
|
||||
const dir = tempDirWithFiles("promise-all-single-async", {
|
||||
"build.ts": `
|
||||
import { build } from "bun";
|
||||
build({
|
||||
entrypoints: ["src/entry.ts"],
|
||||
outdir: "dist",
|
||||
format: "esm",
|
||||
target: "browser",
|
||||
sourcemap: "linked",
|
||||
minify: false,
|
||||
}).then(() => {
|
||||
console.log("Build completed successfully.");
|
||||
}).catch((error) => {
|
||||
console.error("Build failed:", error);
|
||||
})
|
||||
`,
|
||||
"src/entry.ts": `
|
||||
const { AsyncEntryPoint } = await import("./AsyncEntryPoint");
|
||||
AsyncEntryPoint();
|
||||
export {};
|
||||
`,
|
||||
"src/AsyncEntryPoint.ts": `
|
||||
export async function AsyncEntryPoint() {
|
||||
const { BaseElement } = await import("./BaseElement");
|
||||
console.log("Launching AsyncEntryPoint", BaseElement());
|
||||
}
|
||||
`,
|
||||
"src/BaseElement.ts": `
|
||||
import { StoreDependency } from "./StoreDependency";
|
||||
import { BaseElementImport } from "./BaseElementImport";
|
||||
describe("bundler", () => {
|
||||
itBundled("bundler/__promiseAll is tree-shaken when only one async import exists but __esm remains", {
|
||||
files: {
|
||||
"/entry.ts": `
|
||||
const { AsyncEntryPoint } = await import("./AsyncEntryPoint");
|
||||
AsyncEntryPoint();
|
||||
export {};
|
||||
`,
|
||||
"/AsyncEntryPoint.ts": `
|
||||
export async function AsyncEntryPoint() {
|
||||
const { BaseElement } = await import("./BaseElement");
|
||||
console.log("Launching AsyncEntryPoint", BaseElement());
|
||||
}
|
||||
`,
|
||||
"/BaseElement.ts": `
|
||||
import { StoreDependency } from "./StoreDependency";
|
||||
import { BaseElementImport } from "./BaseElementImport";
|
||||
|
||||
const depValue = StoreDependency();
|
||||
const depValue = StoreDependency();
|
||||
|
||||
export const formValue = {
|
||||
key: depValue,
|
||||
};
|
||||
export const formValue = {
|
||||
key: depValue,
|
||||
};
|
||||
|
||||
export const listValue = {
|
||||
key: depValue + "value",
|
||||
};
|
||||
export const listValue = {
|
||||
key: depValue + "value",
|
||||
};
|
||||
|
||||
export function BaseElement() {
|
||||
console.log("BaseElement called", BaseElementImport());
|
||||
return BaseElementImport();
|
||||
}
|
||||
`,
|
||||
"src/BaseElementImport.ts": `
|
||||
import { SecondElementImport } from "./SecondElementImport";
|
||||
export function BaseElementImport() {
|
||||
console.log("BaseElementImport called", SecondElementImport());
|
||||
return SecondElementImport();
|
||||
}
|
||||
`,
|
||||
"src/SecondElementImport.ts": `
|
||||
import { formValue } from "./BaseElement";
|
||||
export function SecondElementImport() {
|
||||
console.log("SecondElementImport called", formValue.key);
|
||||
return formValue.key;
|
||||
}
|
||||
`,
|
||||
"src/StoreDependency.ts": `
|
||||
import { somePromise } from "./StoreDependencyAsync";
|
||||
export function BaseElement() {
|
||||
console.log("BaseElement called", BaseElementImport());
|
||||
return BaseElementImport();
|
||||
}
|
||||
`,
|
||||
"/BaseElementImport.ts": `
|
||||
import { SecondElementImport } from "./SecondElementImport";
|
||||
export function BaseElementImport() {
|
||||
console.log("BaseElementImport called", SecondElementImport());
|
||||
return SecondElementImport();
|
||||
}
|
||||
`,
|
||||
"/SecondElementImport.ts": `
|
||||
import { formValue } from "./BaseElement";
|
||||
export function SecondElementImport() {
|
||||
console.log("SecondElementImport called", formValue.key);
|
||||
return formValue.key;
|
||||
}
|
||||
`,
|
||||
"/StoreDependency.ts": `
|
||||
import { somePromise } from "./StoreDependencyAsync";
|
||||
|
||||
export function StoreDependency() {
|
||||
return "A string from StoreFunc" + somePromise;
|
||||
}
|
||||
`,
|
||||
"src/StoreDependencyAsync.ts": `
|
||||
export const somePromise = await Promise.resolve("Hello World");
|
||||
`,
|
||||
});
|
||||
export function StoreDependency() {
|
||||
return "A string from StoreFunc" + somePromise;
|
||||
}
|
||||
`,
|
||||
"/StoreDependencyAsync.ts": `
|
||||
export const somePromise = await Promise.resolve("Hello World");
|
||||
`,
|
||||
},
|
||||
format: "esm",
|
||||
target: "browser",
|
||||
sourceMap: "linked",
|
||||
minifySyntax: false,
|
||||
minifyWhitespace: false,
|
||||
minifyIdentifiers: false,
|
||||
run: {
|
||||
partialStdout: "Launching AsyncEntryPoint",
|
||||
validate({ stderr }) {
|
||||
expect(stderr).not.toContain('await" can only be used inside an "async" function');
|
||||
},
|
||||
},
|
||||
onAfterBundle(api) {
|
||||
const bundled = api.readFile("out.js");
|
||||
|
||||
// Build the project
|
||||
const buildResult = await Bun.spawn({
|
||||
cmd: [bunExe(), "build.ts"],
|
||||
env: bunEnv,
|
||||
cwd: dir,
|
||||
stdout: "pipe",
|
||||
stderr: "pipe",
|
||||
});
|
||||
expect(bundled).toMatchInlineSnapshot(`
|
||||
"var __defProp = Object.defineProperty;
|
||||
var __export = (target, all) => {
|
||||
for (var name in all)
|
||||
__defProp(target, name, {
|
||||
get: all[name],
|
||||
enumerable: true,
|
||||
configurable: true,
|
||||
set: (newValue) => all[name] = () => newValue
|
||||
});
|
||||
};
|
||||
var __esm = (fn, res) => () => (fn && (res = fn(fn = 0)), res);
|
||||
var __promiseAll = (args) => Promise.all(args);
|
||||
|
||||
const exitCode1 = await buildResult.exited;
|
||||
expect(exitCode1).toBe(0);
|
||||
|
||||
// Read the bundled output
|
||||
const bundledPath = join(dir, "dist", "entry.js");
|
||||
const bundled = await Bun.file(bundledPath).text();
|
||||
|
||||
expect(bundled).toMatchInlineSnapshot(`
|
||||
"var __defProp = Object.defineProperty;
|
||||
var __export = (target, all) => {
|
||||
for (var name in all)
|
||||
__defProp(target, name, {
|
||||
get: all[name],
|
||||
enumerable: true,
|
||||
configurable: true,
|
||||
set: (newValue) => all[name] = () => newValue
|
||||
// StoreDependencyAsync.ts
|
||||
var somePromise;
|
||||
var init_StoreDependencyAsync = __esm(async () => {
|
||||
somePromise = await Promise.resolve("Hello World");
|
||||
});
|
||||
};
|
||||
var __esm = (fn, res) => () => (fn && (res = fn(fn = 0)), res);
|
||||
var __promiseAll = (args) => Promise.all(args);
|
||||
|
||||
// src/StoreDependencyAsync.ts
|
||||
var somePromise;
|
||||
var init_StoreDependencyAsync = __esm(async () => {
|
||||
somePromise = await Promise.resolve("Hello World");
|
||||
});
|
||||
|
||||
// src/StoreDependency.ts
|
||||
function StoreDependency() {
|
||||
return "A string from StoreFunc" + somePromise;
|
||||
}
|
||||
var init_StoreDependency = __esm(async () => {
|
||||
await init_StoreDependencyAsync();
|
||||
});
|
||||
|
||||
// src/SecondElementImport.ts
|
||||
function SecondElementImport() {
|
||||
console.log("SecondElementImport called", formValue.key);
|
||||
return formValue.key;
|
||||
}
|
||||
var init_SecondElementImport = __esm(async () => {
|
||||
await init_BaseElement();
|
||||
});
|
||||
|
||||
// src/BaseElementImport.ts
|
||||
function BaseElementImport() {
|
||||
console.log("BaseElementImport called", SecondElementImport());
|
||||
return SecondElementImport();
|
||||
}
|
||||
var init_BaseElementImport = __esm(async () => {
|
||||
await init_SecondElementImport();
|
||||
});
|
||||
|
||||
// src/BaseElement.ts
|
||||
var exports_BaseElement = {};
|
||||
__export(exports_BaseElement, {
|
||||
listValue: () => listValue,
|
||||
formValue: () => formValue,
|
||||
BaseElement: () => BaseElement
|
||||
});
|
||||
function BaseElement() {
|
||||
console.log("BaseElement called", BaseElementImport());
|
||||
return BaseElementImport();
|
||||
}
|
||||
var depValue, formValue, listValue;
|
||||
var init_BaseElement = __esm(async () => {
|
||||
await __promiseAll([
|
||||
init_StoreDependency(),
|
||||
init_BaseElementImport()
|
||||
]);
|
||||
depValue = StoreDependency();
|
||||
formValue = {
|
||||
key: depValue
|
||||
};
|
||||
listValue = {
|
||||
key: depValue + "value"
|
||||
};
|
||||
});
|
||||
|
||||
// src/AsyncEntryPoint.ts
|
||||
var exports_AsyncEntryPoint = {};
|
||||
__export(exports_AsyncEntryPoint, {
|
||||
AsyncEntryPoint: () => AsyncEntryPoint
|
||||
});
|
||||
async function AsyncEntryPoint() {
|
||||
const { BaseElement: BaseElement2 } = await init_BaseElement().then(() => exports_BaseElement);
|
||||
console.log("Launching AsyncEntryPoint", BaseElement2());
|
||||
}
|
||||
|
||||
// src/entry.ts
|
||||
var { AsyncEntryPoint: AsyncEntryPoint2 } = await Promise.resolve().then(() => exports_AsyncEntryPoint);
|
||||
AsyncEntryPoint2();
|
||||
|
||||
//# debugId=BFB0A84A2F1B802064756E2164756E21
|
||||
//# sourceMappingURL=entry.js.map
|
||||
"
|
||||
`);
|
||||
|
||||
// MUST have __esm because of circular dependency requiring wrapping
|
||||
expect(bundled).toContain("__esm");
|
||||
expect(bundled).toContain("var init_");
|
||||
|
||||
// Should have __promiseAll because BaseElement has multiple dependencies
|
||||
// even though only one is async (due to circular deps both need to be awaited)
|
||||
expect(bundled).toContain("__promiseAll");
|
||||
expect(bundled).toContain("var __promiseAll = ");
|
||||
|
||||
// Verify it's used with both dependencies
|
||||
expect(bundled).toMatch(/await\s+__promiseAll\s*\(\s*\[/);
|
||||
|
||||
// Also verify the bundled code can execute without syntax errors
|
||||
const runResult = await Bun.spawn({
|
||||
cmd: [bunExe(), bundledPath],
|
||||
env: bunEnv,
|
||||
cwd: dir,
|
||||
stdout: "pipe",
|
||||
stderr: "pipe",
|
||||
});
|
||||
|
||||
const [stdout, stderr, exitCode] = await Promise.all([
|
||||
new Response(runResult.stdout).text(),
|
||||
new Response(runResult.stderr).text(),
|
||||
runResult.exited,
|
||||
]);
|
||||
|
||||
// Should not have syntax errors
|
||||
expect(stderr).not.toContain('await" can only be used inside an "async" function');
|
||||
expect(exitCode).toBe(0);
|
||||
expect(stdout).toContain("Launching AsyncEntryPoint");
|
||||
});
|
||||
|
||||
test("__promiseAll is included when multiple async imports exist with __esm", async () => {
|
||||
const dir = tempDirWithFiles("promise-all-multiple-async", {
|
||||
"build.ts": `
|
||||
import { build } from "bun";
|
||||
build({
|
||||
entrypoints: ["src/entry.ts"],
|
||||
outdir: "dist",
|
||||
format: "esm",
|
||||
target: "browser",
|
||||
sourcemap: "linked",
|
||||
minify: false,
|
||||
}).then(() => {
|
||||
console.log("Build completed successfully.");
|
||||
}).catch((error) => {
|
||||
console.error("Build failed:", error);
|
||||
})
|
||||
`,
|
||||
"src/entry.ts": `
|
||||
const { AsyncEntryPoint } = await import("./AsyncEntryPoint");
|
||||
AsyncEntryPoint();
|
||||
export {};
|
||||
`,
|
||||
"src/AsyncEntryPoint.ts": `
|
||||
export async function AsyncEntryPoint() {
|
||||
const { BaseElement } = await import("./BaseElement");
|
||||
console.log("Launching AsyncEntryPoint", BaseElement());
|
||||
}
|
||||
`,
|
||||
"src/BaseElement.ts": `
|
||||
import { StoreDependency } from "./StoreDependency";
|
||||
import { StoreDependency2 } from "./StoreDependency2";
|
||||
import { BaseElementImport } from "./BaseElementImport";
|
||||
|
||||
const depValue = StoreDependency();
|
||||
const depValue2 = StoreDependency2();
|
||||
|
||||
export const formValue = {
|
||||
key: depValue + depValue2,
|
||||
};
|
||||
|
||||
export const listValue = {
|
||||
key: depValue + "value",
|
||||
};
|
||||
|
||||
export function BaseElement() {
|
||||
console.log("BaseElement called", BaseElementImport());
|
||||
return BaseElementImport();
|
||||
}
|
||||
`,
|
||||
"src/BaseElementImport.ts": `
|
||||
import { SecondElementImport } from "./SecondElementImport";
|
||||
export function BaseElementImport() {
|
||||
console.log("BaseElementImport called", SecondElementImport());
|
||||
return SecondElementImport();
|
||||
}
|
||||
`,
|
||||
"src/SecondElementImport.ts": `
|
||||
import { formValue } from "./BaseElement";
|
||||
export function SecondElementImport() {
|
||||
console.log("SecondElementImport called", formValue.key);
|
||||
return formValue.key;
|
||||
}
|
||||
`,
|
||||
"src/StoreDependency.ts": `
|
||||
import { somePromise } from "./StoreDependencyAsync";
|
||||
|
||||
export function StoreDependency() {
|
||||
return "A string from StoreFunc" + somePromise;
|
||||
}
|
||||
`,
|
||||
"src/StoreDependencyAsync.ts": `
|
||||
export const somePromise = await Promise.resolve("Hello World");
|
||||
`,
|
||||
"src/StoreDependency2.ts": `
|
||||
import { somePromise2 } from "./StoreDependencyAsync2";
|
||||
|
||||
export function StoreDependency2() {
|
||||
return "Another string" + somePromise2;
|
||||
}
|
||||
`,
|
||||
"src/StoreDependencyAsync2.ts": `
|
||||
export const somePromise2 = await Promise.resolve(" World2");
|
||||
`,
|
||||
});
|
||||
|
||||
// Build the project
|
||||
const buildResult = await Bun.spawn({
|
||||
cmd: [bunExe(), "build.ts"],
|
||||
env: bunEnv,
|
||||
cwd: dir,
|
||||
stdout: "pipe",
|
||||
stderr: "pipe",
|
||||
});
|
||||
|
||||
const exitCode1 = await buildResult.exited;
|
||||
expect(exitCode1).toBe(0);
|
||||
|
||||
// Read the bundled output
|
||||
const bundledPath = join(dir, "dist", "entry.js");
|
||||
const bundled = await Bun.file(bundledPath).text();
|
||||
|
||||
// MUST have __esm because of circular dependency requiring wrapping
|
||||
expect(bundled).toContain("__esm");
|
||||
expect(bundled).toContain("var init_");
|
||||
|
||||
// MUST have __promiseAll since there are TWO async dependencies
|
||||
expect(bundled).toContain("__promiseAll");
|
||||
expect(bundled).toContain("var __promiseAll = ");
|
||||
|
||||
// Verify it's actually used in the code with multiple async deps
|
||||
expect(bundled).toMatch(/await\s+__promiseAll\s*\(\s*\[/);
|
||||
|
||||
// Also verify the bundled code can execute without syntax errors
|
||||
const runResult = await Bun.spawn({
|
||||
cmd: [bunExe(), bundledPath],
|
||||
env: bunEnv,
|
||||
cwd: dir,
|
||||
stdout: "pipe",
|
||||
stderr: "pipe",
|
||||
});
|
||||
|
||||
const [stdout, stderr, exitCode] = await Promise.all([
|
||||
new Response(runResult.stdout).text(),
|
||||
new Response(runResult.stderr).text(),
|
||||
runResult.exited,
|
||||
]);
|
||||
|
||||
// Should not have syntax errors
|
||||
expect(stderr).not.toContain('await" can only be used inside an "async" function');
|
||||
expect(exitCode).toBe(0);
|
||||
expect(stdout).toContain("Launching AsyncEntryPoint");
|
||||
});
|
||||
|
||||
test("__promiseAll is tree-shaken when no async imports despite circular deps with __esm", async () => {
|
||||
const dir = tempDirWithFiles("promise-all-no-async", {
|
||||
"build.ts": `
|
||||
import { build } from "bun";
|
||||
build({
|
||||
entrypoints: ["src/entry.ts"],
|
||||
outdir: "dist",
|
||||
format: "esm",
|
||||
target: "browser",
|
||||
sourcemap: "linked",
|
||||
minify: false,
|
||||
}).then(() => {
|
||||
console.log("Build completed successfully.");
|
||||
}).catch((error) => {
|
||||
console.error("Build failed:", error);
|
||||
})
|
||||
`,
|
||||
"src/entry.ts": `
|
||||
const { AsyncEntryPoint } = await import("./AsyncEntryPoint");
|
||||
AsyncEntryPoint();
|
||||
export {};
|
||||
`,
|
||||
"src/AsyncEntryPoint.ts": `
|
||||
export async function AsyncEntryPoint() {
|
||||
const { BaseElement } = await import("./BaseElement");
|
||||
console.log("Launching AsyncEntryPoint", BaseElement());
|
||||
}
|
||||
`,
|
||||
"src/BaseElement.ts": `
|
||||
import { BaseElementImport } from "./BaseElementImport";
|
||||
|
||||
export const formValue = {
|
||||
key: "static value",
|
||||
};
|
||||
|
||||
export const listValue = {
|
||||
key: "static list value",
|
||||
};
|
||||
|
||||
export function BaseElement() {
|
||||
console.log("BaseElement called", BaseElementImport());
|
||||
return BaseElementImport();
|
||||
}
|
||||
`,
|
||||
"src/BaseElementImport.ts": `
|
||||
import { SecondElementImport } from "./SecondElementImport";
|
||||
export function BaseElementImport() {
|
||||
console.log("BaseElementImport called", SecondElementImport());
|
||||
return SecondElementImport();
|
||||
}
|
||||
`,
|
||||
"src/SecondElementImport.ts": `
|
||||
import { formValue } from "./BaseElement";
|
||||
export function SecondElementImport() {
|
||||
console.log("SecondElementImport called", formValue.key);
|
||||
return formValue.key;
|
||||
}
|
||||
`,
|
||||
});
|
||||
|
||||
// Build the project
|
||||
const buildResult = await Bun.spawn({
|
||||
cmd: [bunExe(), "build.ts"],
|
||||
env: bunEnv,
|
||||
cwd: dir,
|
||||
stdout: "pipe",
|
||||
stderr: "pipe",
|
||||
});
|
||||
|
||||
const exitCode1 = await buildResult.exited;
|
||||
expect(exitCode1).toBe(0);
|
||||
|
||||
// Read the bundled output
|
||||
const bundledPath = join(dir, "dist", "entry.js");
|
||||
const bundled = await Bun.file(bundledPath).text();
|
||||
|
||||
expect(bundled).toMatchInlineSnapshot(`
|
||||
"var __defProp = Object.defineProperty;
|
||||
var __export = (target, all) => {
|
||||
for (var name in all)
|
||||
__defProp(target, name, {
|
||||
get: all[name],
|
||||
enumerable: true,
|
||||
configurable: true,
|
||||
set: (newValue) => all[name] = () => newValue
|
||||
// StoreDependency.ts
|
||||
function StoreDependency() {
|
||||
return "A string from StoreFunc" + somePromise;
|
||||
}
|
||||
var init_StoreDependency = __esm(async () => {
|
||||
await init_StoreDependencyAsync();
|
||||
});
|
||||
};
|
||||
var __esm = (fn, res) => () => (fn && (res = fn(fn = 0)), res);
|
||||
|
||||
// src/SecondElementImport.ts
|
||||
function SecondElementImport() {
|
||||
console.log("SecondElementImport called", formValue.key);
|
||||
return formValue.key;
|
||||
}
|
||||
var init_SecondElementImport = __esm(() => {
|
||||
init_BaseElement();
|
||||
});
|
||||
// SecondElementImport.ts
|
||||
function SecondElementImport() {
|
||||
console.log("SecondElementImport called", formValue.key);
|
||||
return formValue.key;
|
||||
}
|
||||
var init_SecondElementImport = __esm(async () => {
|
||||
await init_BaseElement();
|
||||
});
|
||||
|
||||
// src/BaseElementImport.ts
|
||||
function BaseElementImport() {
|
||||
console.log("BaseElementImport called", SecondElementImport());
|
||||
return SecondElementImport();
|
||||
}
|
||||
var init_BaseElementImport = __esm(() => {
|
||||
init_SecondElementImport();
|
||||
});
|
||||
// BaseElementImport.ts
|
||||
function BaseElementImport() {
|
||||
console.log("BaseElementImport called", SecondElementImport());
|
||||
return SecondElementImport();
|
||||
}
|
||||
var init_BaseElementImport = __esm(async () => {
|
||||
await init_SecondElementImport();
|
||||
});
|
||||
|
||||
// src/BaseElement.ts
|
||||
var exports_BaseElement = {};
|
||||
__export(exports_BaseElement, {
|
||||
listValue: () => listValue,
|
||||
formValue: () => formValue,
|
||||
BaseElement: () => BaseElement
|
||||
});
|
||||
function BaseElement() {
|
||||
console.log("BaseElement called", BaseElementImport());
|
||||
return BaseElementImport();
|
||||
}
|
||||
var formValue, listValue;
|
||||
var init_BaseElement = __esm(() => {
|
||||
init_BaseElementImport();
|
||||
formValue = {
|
||||
key: "static value"
|
||||
};
|
||||
listValue = {
|
||||
key: "static list value"
|
||||
};
|
||||
});
|
||||
// BaseElement.ts
|
||||
var exports_BaseElement = {};
|
||||
__export(exports_BaseElement, {
|
||||
listValue: () => listValue,
|
||||
formValue: () => formValue,
|
||||
BaseElement: () => BaseElement
|
||||
});
|
||||
function BaseElement() {
|
||||
console.log("BaseElement called", BaseElementImport());
|
||||
return BaseElementImport();
|
||||
}
|
||||
var depValue, formValue, listValue;
|
||||
var init_BaseElement = __esm(async () => {
|
||||
await __promiseAll([
|
||||
init_StoreDependency(),
|
||||
init_BaseElementImport()
|
||||
]);
|
||||
depValue = StoreDependency();
|
||||
formValue = {
|
||||
key: depValue
|
||||
};
|
||||
listValue = {
|
||||
key: depValue + "value"
|
||||
};
|
||||
});
|
||||
|
||||
// src/AsyncEntryPoint.ts
|
||||
var exports_AsyncEntryPoint = {};
|
||||
__export(exports_AsyncEntryPoint, {
|
||||
AsyncEntryPoint: () => AsyncEntryPoint
|
||||
});
|
||||
async function AsyncEntryPoint() {
|
||||
const { BaseElement: BaseElement2 } = await Promise.resolve().then(() => (init_BaseElement(), exports_BaseElement));
|
||||
console.log("Launching AsyncEntryPoint", BaseElement2());
|
||||
}
|
||||
// AsyncEntryPoint.ts
|
||||
var exports_AsyncEntryPoint = {};
|
||||
__export(exports_AsyncEntryPoint, {
|
||||
AsyncEntryPoint: () => AsyncEntryPoint
|
||||
});
|
||||
async function AsyncEntryPoint() {
|
||||
const { BaseElement: BaseElement2 } = await init_BaseElement().then(() => exports_BaseElement);
|
||||
console.log("Launching AsyncEntryPoint", BaseElement2());
|
||||
}
|
||||
|
||||
// src/entry.ts
|
||||
var { AsyncEntryPoint: AsyncEntryPoint2 } = await Promise.resolve().then(() => exports_AsyncEntryPoint);
|
||||
AsyncEntryPoint2();
|
||||
// entry.ts
|
||||
var { AsyncEntryPoint: AsyncEntryPoint2 } = await Promise.resolve().then(() => exports_AsyncEntryPoint);
|
||||
AsyncEntryPoint2();
|
||||
|
||||
//# debugId=9153B63E16185E4364756E2164756E21
|
||||
//# sourceMappingURL=entry.js.map
|
||||
"
|
||||
`);
|
||||
//# debugId=741426CCC2D50C3364756E2164756E21
|
||||
//# sourceMappingURL=out.js.map
|
||||
"
|
||||
`);
|
||||
|
||||
// MUST have __esm because of circular dependency requiring wrapping
|
||||
expect(bundled).toContain("__esm");
|
||||
expect(bundled).toContain("var init_");
|
||||
// MUST have __esm because of circular dependency requiring wrapping
|
||||
expect(bundled).toContain("__esm");
|
||||
expect(bundled).toContain("var init_");
|
||||
|
||||
// Currently __promiseAll is always included with ESM wrappers (not tree-shaken)
|
||||
// but it shouldn't be used since there are no async dependencies
|
||||
expect(bundled).not.toContain("__promiseAll");
|
||||
expect(bundled).not.toContain("var __promiseAll = ");
|
||||
// Should have __promiseAll because BaseElement has multiple dependencies
|
||||
// even though only one is async (due to circular deps both need to be awaited)
|
||||
expect(bundled).toContain("__promiseAll");
|
||||
expect(bundled).toContain("var __promiseAll = ");
|
||||
|
||||
// Verify it's NOT actually used in any init functions
|
||||
expect(bundled).not.toMatch(/await\s+__promiseAll\s*\(/);
|
||||
|
||||
// Also verify the bundled code can execute without syntax errors
|
||||
const runResult = await Bun.spawn({
|
||||
cmd: [bunExe(), bundledPath],
|
||||
env: bunEnv,
|
||||
cwd: dir,
|
||||
stdout: "pipe",
|
||||
stderr: "pipe",
|
||||
// Verify it's used with both dependencies
|
||||
expect(bundled).toMatch(/await\s+__promiseAll\s*\(\s*\[/);
|
||||
},
|
||||
});
|
||||
|
||||
const [stdout, stderr, exitCode] = await Promise.all([
|
||||
new Response(runResult.stdout).text(),
|
||||
new Response(runResult.stderr).text(),
|
||||
runResult.exited,
|
||||
]);
|
||||
itBundled("bundler/__promiseAll is included when multiple async imports exist with __esm", {
|
||||
files: {
|
||||
"/entry.ts": `
|
||||
const { AsyncEntryPoint } = await import("./AsyncEntryPoint");
|
||||
AsyncEntryPoint();
|
||||
export {};
|
||||
`,
|
||||
"/AsyncEntryPoint.ts": `
|
||||
export async function AsyncEntryPoint() {
|
||||
const { BaseElement } = await import("./BaseElement");
|
||||
console.log("Launching AsyncEntryPoint", BaseElement());
|
||||
}
|
||||
`,
|
||||
"/BaseElement.ts": `
|
||||
import { StoreDependency } from "./StoreDependency";
|
||||
import { StoreDependency2 } from "./StoreDependency2";
|
||||
import { BaseElementImport } from "./BaseElementImport";
|
||||
|
||||
// Should not have syntax errors
|
||||
expect(stderr).not.toContain('await" can only be used inside an "async" function');
|
||||
expect(exitCode).toBe(0);
|
||||
expect(stdout).toContain("Launching AsyncEntryPoint");
|
||||
const depValue = StoreDependency();
|
||||
const depValue2 = StoreDependency2();
|
||||
|
||||
export const formValue = {
|
||||
key: depValue + depValue2,
|
||||
};
|
||||
|
||||
export const listValue = {
|
||||
key: depValue + "value",
|
||||
};
|
||||
|
||||
export function BaseElement() {
|
||||
console.log("BaseElement called", BaseElementImport());
|
||||
return BaseElementImport();
|
||||
}
|
||||
`,
|
||||
"/BaseElementImport.ts": `
|
||||
import { SecondElementImport } from "./SecondElementImport";
|
||||
export function BaseElementImport() {
|
||||
console.log("BaseElementImport called", SecondElementImport());
|
||||
return SecondElementImport();
|
||||
}
|
||||
`,
|
||||
"/SecondElementImport.ts": `
|
||||
import { formValue } from "./BaseElement";
|
||||
export function SecondElementImport() {
|
||||
console.log("SecondElementImport called", formValue.key);
|
||||
return formValue.key;
|
||||
}
|
||||
`,
|
||||
"/StoreDependency.ts": `
|
||||
import { somePromise } from "./StoreDependencyAsync";
|
||||
|
||||
export function StoreDependency() {
|
||||
return "A string from StoreFunc" + somePromise;
|
||||
}
|
||||
`,
|
||||
"/StoreDependencyAsync.ts": `
|
||||
export const somePromise = await Promise.resolve("Hello World");
|
||||
`,
|
||||
"/StoreDependency2.ts": `
|
||||
import { somePromise2 } from "./StoreDependencyAsync2";
|
||||
|
||||
export function StoreDependency2() {
|
||||
return "Another string" + somePromise2;
|
||||
}
|
||||
`,
|
||||
"/StoreDependencyAsync2.ts": `
|
||||
export const somePromise2 = await Promise.resolve(" World2");
|
||||
`,
|
||||
},
|
||||
format: "esm",
|
||||
target: "browser",
|
||||
sourceMap: "linked",
|
||||
minifySyntax: false,
|
||||
minifyWhitespace: false,
|
||||
minifyIdentifiers: false,
|
||||
run: {
|
||||
partialStdout: "Launching AsyncEntryPoint",
|
||||
validate({ stderr }) {
|
||||
expect(stderr).not.toContain('await" can only be used inside an "async" function');
|
||||
},
|
||||
},
|
||||
onAfterBundle(api) {
|
||||
const bundled = api.readFile("out.js");
|
||||
|
||||
// MUST have __esm because of circular dependency requiring wrapping
|
||||
expect(bundled).toContain("__esm");
|
||||
expect(bundled).toContain("var init_");
|
||||
|
||||
// MUST have __promiseAll since there are TWO async dependencies
|
||||
expect(bundled).toContain("__promiseAll");
|
||||
expect(bundled).toContain("var __promiseAll = ");
|
||||
|
||||
// Verify it's actually used in the code with multiple async deps
|
||||
expect(bundled).toMatch(/await\s+__promiseAll\s*\(\s*\[/);
|
||||
},
|
||||
});
|
||||
|
||||
itBundled("bundler/__promiseAll is tree-shaken when no async imports despite circular deps with __esm", {
|
||||
files: {
|
||||
"/entry.ts": `
|
||||
const { AsyncEntryPoint } = await import("./AsyncEntryPoint");
|
||||
AsyncEntryPoint();
|
||||
export {};
|
||||
`,
|
||||
"/AsyncEntryPoint.ts": `
|
||||
export async function AsyncEntryPoint() {
|
||||
const { BaseElement } = await import("./BaseElement");
|
||||
console.log("Launching AsyncEntryPoint", BaseElement());
|
||||
}
|
||||
`,
|
||||
"/BaseElement.ts": `
|
||||
import { BaseElementImport } from "./BaseElementImport";
|
||||
|
||||
export const formValue = {
|
||||
key: "static value",
|
||||
};
|
||||
|
||||
export const listValue = {
|
||||
key: "static list value",
|
||||
};
|
||||
|
||||
export function BaseElement() {
|
||||
console.log("BaseElement called", BaseElementImport());
|
||||
return BaseElementImport();
|
||||
}
|
||||
`,
|
||||
"/BaseElementImport.ts": `
|
||||
import { SecondElementImport } from "./SecondElementImport";
|
||||
export function BaseElementImport() {
|
||||
console.log("BaseElementImport called", SecondElementImport());
|
||||
return SecondElementImport();
|
||||
}
|
||||
`,
|
||||
"/SecondElementImport.ts": `
|
||||
import { formValue } from "./BaseElement";
|
||||
export function SecondElementImport() {
|
||||
console.log("SecondElementImport called", formValue.key);
|
||||
return formValue.key;
|
||||
}
|
||||
`,
|
||||
},
|
||||
format: "esm",
|
||||
target: "browser",
|
||||
sourceMap: "linked",
|
||||
minifySyntax: false,
|
||||
minifyWhitespace: false,
|
||||
minifyIdentifiers: false,
|
||||
run: {
|
||||
partialStdout: "Launching AsyncEntryPoint",
|
||||
validate({ stderr }) {
|
||||
expect(stderr).not.toContain('await" can only be used inside an "async" function');
|
||||
},
|
||||
},
|
||||
onAfterBundle(api) {
|
||||
const bundled = api.readFile("out.js");
|
||||
|
||||
expect(bundled).toMatchInlineSnapshot(`
|
||||
"var __defProp = Object.defineProperty;
|
||||
var __export = (target, all) => {
|
||||
for (var name in all)
|
||||
__defProp(target, name, {
|
||||
get: all[name],
|
||||
enumerable: true,
|
||||
configurable: true,
|
||||
set: (newValue) => all[name] = () => newValue
|
||||
});
|
||||
};
|
||||
var __esm = (fn, res) => () => (fn && (res = fn(fn = 0)), res);
|
||||
|
||||
// SecondElementImport.ts
|
||||
function SecondElementImport() {
|
||||
console.log("SecondElementImport called", formValue.key);
|
||||
return formValue.key;
|
||||
}
|
||||
var init_SecondElementImport = __esm(() => {
|
||||
init_BaseElement();
|
||||
});
|
||||
|
||||
// BaseElementImport.ts
|
||||
function BaseElementImport() {
|
||||
console.log("BaseElementImport called", SecondElementImport());
|
||||
return SecondElementImport();
|
||||
}
|
||||
var init_BaseElementImport = __esm(() => {
|
||||
init_SecondElementImport();
|
||||
});
|
||||
|
||||
// BaseElement.ts
|
||||
var exports_BaseElement = {};
|
||||
__export(exports_BaseElement, {
|
||||
listValue: () => listValue,
|
||||
formValue: () => formValue,
|
||||
BaseElement: () => BaseElement
|
||||
});
|
||||
function BaseElement() {
|
||||
console.log("BaseElement called", BaseElementImport());
|
||||
return BaseElementImport();
|
||||
}
|
||||
var formValue, listValue;
|
||||
var init_BaseElement = __esm(() => {
|
||||
init_BaseElementImport();
|
||||
formValue = {
|
||||
key: "static value"
|
||||
};
|
||||
listValue = {
|
||||
key: "static list value"
|
||||
};
|
||||
});
|
||||
|
||||
// AsyncEntryPoint.ts
|
||||
var exports_AsyncEntryPoint = {};
|
||||
__export(exports_AsyncEntryPoint, {
|
||||
AsyncEntryPoint: () => AsyncEntryPoint
|
||||
});
|
||||
async function AsyncEntryPoint() {
|
||||
const { BaseElement: BaseElement2 } = await Promise.resolve().then(() => (init_BaseElement(), exports_BaseElement));
|
||||
console.log("Launching AsyncEntryPoint", BaseElement2());
|
||||
}
|
||||
|
||||
// entry.ts
|
||||
var { AsyncEntryPoint: AsyncEntryPoint2 } = await Promise.resolve().then(() => exports_AsyncEntryPoint);
|
||||
AsyncEntryPoint2();
|
||||
|
||||
//# debugId=27B6A8D5F1ED83DA64756E2164756E21
|
||||
//# sourceMappingURL=out.js.map
|
||||
"
|
||||
`);
|
||||
|
||||
// MUST have __esm because of circular dependency requiring wrapping
|
||||
expect(bundled).toContain("__esm");
|
||||
expect(bundled).toContain("var init_");
|
||||
|
||||
// Currently __promiseAll is always included with ESM wrappers (not tree-shaken)
|
||||
// but it shouldn't be used since there are no async dependencies
|
||||
expect(bundled).not.toContain("__promiseAll");
|
||||
expect(bundled).not.toContain("var __promiseAll = ");
|
||||
|
||||
// Verify it's NOT actually used in any init functions
|
||||
expect(bundled).not.toMatch(/await\s+__promiseAll\s*\(/);
|
||||
},
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user