mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-09 18:38:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: ban std.debug.assert (#10168)

Browse Source 
* Ban `std.debug.assert`

* Create .clangd

* Update lint.yml

* Update linter.ts

* update

* lint

* Update linter.ts

* Update linter.ts

* update

* Update linter.ts

* update

* Update linter.ts

* more

* Update install.zig

* words

* Remove UB
This commit is contained in:
Jarred Sumner
2024-04-11 17:52:29 -07:00
committed by GitHub
parent 0f10d4f1be
commit 688844b472
149 changed files with 1314 additions and 1105 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
src/string.zig
View File

@@ -72,19 +72,19 @@ pub const WTFStringImplStruct = extern struct {
}
pub inline fn utf16Slice(self: WTFStringImpl) []const u16 {
std.debug.assert(!is8Bit(self));
bun.assert(!is8Bit(self));
return self.m_ptr.utf16[0..length(self)];
}
pub inline fn latin1Slice(self: WTFStringImpl) []const u8 {
std.debug.assert(is8Bit(self));
bun.assert(is8Bit(self));
return self.m_ptr.latin1[0..length(self)];
}
/// Caller must ensure that the string is 8-bit and ASCII.
pub inline fn utf8Slice(self: WTFStringImpl) []const u8 {
if (comptime bun.Environment.allow_assert)
std.debug.assert(canUseAsUTF8(self));
bun.assert(canUseAsUTF8(self));
return self.m_ptr.latin1[0..length(self)];
}
@@ -99,11 +99,11 @@ pub const WTFStringImplStruct = extern struct {
pub inline fn deref(self: WTFStringImpl) void {
JSC.markBinding(@src());
const current_count = self.refCount();
std.debug.assert(current_count > 0);
bun.assert(current_count > 0);
Bun__WTFStringImpl__deref(self);
if (comptime bun.Environment.allow_assert) {
if (current_count > 1) {
std.debug.assert(self.refCount() < current_count or self.isStatic());
bun.assert(self.refCount() < current_count or self.isStatic());
}
}
}
@@ -111,9 +111,9 @@ pub const WTFStringImplStruct = extern struct {
pub inline fn ref(self: WTFStringImpl) void {
JSC.markBinding(@src());
const current_count = self.refCount();
std.debug.assert(current_count > 0);
bun.assert(current_count > 0);
Bun__WTFStringImpl__ref(self);
std.debug.assert(self.refCount() > current_count or self.isStatic());
bun.assert(self.refCount() > current_count or self.isStatic());
}
pub fn toLatin1Slice(this: WTFStringImpl) ZigString.Slice {
@@ -240,8 +240,8 @@ pub const StringImplAllocator = struct {
_: usize,
) void {
var this = bun.cast(WTFStringImpl, ptr);
std.debug.assert(this.latin1Slice().ptr == buf.ptr);
std.debug.assert(this.latin1Slice().len == buf.len);
bun.assert(this.latin1Slice().ptr == buf.ptr);
bun.assert(this.latin1Slice().len == buf.len);
this.deref();
}
@@ -337,7 +337,7 @@ pub const String = extern struct {
}
fn createUninitializedLatin1(len: usize) struct { String, []u8 } {
std.debug.assert(len > 0);
bun.assert(len > 0);
const string = BunString__fromLatin1Unitialized(len);
const wtf = string.value.WTFStringImpl;
return .{
@@ -347,7 +347,7 @@ pub const String = extern struct {
}
fn createUninitializedUTF16(len: usize) struct { String, []u16 } {
std.debug.assert(len > 0);
bun.assert(len > 0);
const string = BunString__fromUTF16Unitialized(len);
const wtf = string.value.WTFStringImpl;
return .{
@@ -377,7 +377,7 @@ pub const String = extern struct {
comptime kind: WTFStringEncoding,
len: usize,
) struct { String, [](kind.Byte()) } {
std.debug.assert(len > 0);
bun.assert(len > 0);
return switch (comptime kind) {
.latin1 => createUninitializedLatin1(len),
.utf16 => createUninitializedUTF16(len),
@@ -555,7 +555,7 @@ pub const String = extern struct {
pub fn createExternal(bytes: []const u8, isLatin1: bool, ctx: ?*anyopaque, callback: ?*const ExternalStringImplFreeFunction) String {
JSC.markBinding(@src());
std.debug.assert(bytes.len > 0);
bun.assert(bytes.len > 0);
return BunString__createExternal(bytes.ptr, bytes.len, isLatin1, ctx, callback);
}
@@ -571,7 +571,7 @@ pub const String = extern struct {
pub fn createExternalGloballyAllocated(comptime kind: WTFStringEncoding, bytes: []kind.Byte()) String {
JSC.markBinding(@src());
std.debug.assert(bytes.len > 0);
bun.assert(bytes.len > 0);
return switch (comptime kind) {
.latin1 => BunString__createExternalGloballyAllocatedLatin1(bytes.ptr, bytes.len),
@@ -775,8 +775,8 @@ pub const String = extern struct {
pub inline fn utf8(self: String) []const u8 {
if (comptime bun.Environment.allow_assert) {
std.debug.assert(self.tag == .ZigString or self.tag == .StaticZigString);
std.debug.assert(self.canBeUTF8());
bun.assert(self.tag == .ZigString or self.tag == .StaticZigString);
bun.assert(self.canBeUTF8());
}
return self.value.ZigString.slice();
}
@@ -872,8 +872,8 @@ pub const String = extern struct {
}
if (comptime bun.Environment.allow_assert) {
std.debug.assert(!isWTFAllocator(slice.allocator.get().?)); // toUTF8WithoutRef() should never return a WTF allocator
std.debug.assert(slice.allocator.get().?.vtable == allocator.vtable); // assert that the allocator is the same
bun.assert(!isWTFAllocator(slice.allocator.get().?)); // toUTF8WithoutRef() should never return a WTF allocator
bun.assert(slice.allocator.get().?.vtable == allocator.vtable); // assert that the allocator is the same
}
// We've already cloned the string, so let's just return the slice.
@@ -901,8 +901,8 @@ pub const String = extern struct {
}
if (comptime bun.Environment.allow_assert) {
std.debug.assert(!isWTFAllocator(slice.allocator.get().?)); // toUTF8WithoutRef() should never return a WTF allocator
std.debug.assert(slice.allocator.get().?.vtable == allocator.vtable); // assert that the allocator is the same
bun.assert(!isWTFAllocator(slice.allocator.get().?)); // toUTF8WithoutRef() should never return a WTF allocator
bun.assert(slice.allocator.get().?.vtable == allocator.vtable); // assert that the allocator is the same
}
// We did have to clone the string. Let's avoid keeping the WTFStringImpl around
@@ -951,7 +951,7 @@ pub const String = extern struct {
pub fn charAt(this: String, index: usize) u16 {
if (comptime bun.Environment.allow_assert) {
std.debug.assert(index < this.length());
bun.assert(index < this.length());
}
return switch (this.tag) {
.WTFStringImpl => if (this.value.WTFStringImpl.is8Bit()) @intCast(this.value.WTFStringImpl.utf8Slice()[index]) else this.value.WTFStringImpl.utf16Slice()[index],
@@ -962,7 +962,7 @@ pub const String = extern struct {
pub fn charAtU8(this: String, index: usize) u8 {
if (comptime bun.Environment.allow_assert) {
std.debug.assert(index < this.length());
bun.assert(index < this.length());
}
return switch (this.tag) {
.WTFStringImpl => if (this.value.WTFStringImpl.is8Bit()) this.value.WTFStringImpl.utf8Slice()[index] else @truncate(this.value.WTFStringImpl.utf16Slice()[index]),
@@ -972,7 +972,7 @@ pub const String = extern struct {
}
pub fn indexOfAsciiChar(this: String, chr: u8) ?usize {
std.debug.assert(chr < 128);
bun.assert(chr < 128);
return switch (this.isUTF16()) {
true => std.mem.indexOfScalar(u16, this.utf16(), @intCast(chr)),
false => bun.strings.indexOfCharUsize(this.byteSlice(), chr),
@@ -1026,7 +1026,7 @@ pub const String = extern struct {
const bytes = this.byteSlice();
inline for (0..values.len) |i| {
std.debug.assert(bytes.len == values[i].len);
bun.assert(bytes.len == values[i].len);
if (bun.strings.eqlComptimeCheckLenWithType(u8, bytes, values[i], false)) {
return i;
}
@@ -1067,7 +1067,7 @@ pub const String = extern struct {
const bytes = this.byteSlice();
inline for (0..values.len) |i| {
std.debug.assert(bytes.len == values[i].len);
bun.assert(bytes.len == values[i].len);
if (bun.strings.eqlCaseInsensitiveASCIIIgnoreLength(bytes, values[i])) {
return i;
}
@@ -1220,7 +1220,7 @@ pub const SliceWithUnderlyingString = struct {
pub inline fn reportExtraMemory(this: *SliceWithUnderlyingString, vm: *JSC.VM) void {
if (comptime bun.Environment.allow_assert) {
std.debug.assert(!this.did_report_extra_memory_debug);
bun.assert(!this.did_report_extra_memory_debug);
this.did_report_extra_memory_debug = true;
}
this.utf8.reportExtraMemory(vm);
@@ -1306,7 +1306,7 @@ pub const SliceWithUnderlyingString = struct {
if ((this.underlying.tag == .Dead or this.underlying.tag == .Empty) and this.utf8.length() > 0) {
if (comptime bun.Environment.allow_assert) {
if (this.utf8.allocator.get()) |allocator| {
std.debug.assert(!String.isWTFAllocator(allocator)); // We should never enter this state.
bun.assert(!String.isWTFAllocator(allocator)); // We should never enter this state.
}
}