mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-02 15:08:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(build-jsc): enable REMOTE_INSPECTOR for macOS release builds (#26453)

Browse Source 
### What does this PR do?

  Move `-DENABLE_REMOTE_INSPECTOR=ON` from the debug-only flags to the
  macOS common flags so it applies to all build configurations (debug,
  release, lto). This was already the case for Linux and Windows.

  Without this, `build:release:local` fails because BunDebugger.cpp and
InspectorLifecycleAgent.cpp unconditionally use JSC inspector APIs that
  are only available when REMOTE_INSPECTOR is enabled.

### How did you verify your code works?

Build locally
This commit is contained in:
SUZUKI Sosuke
2026-01-26 17:19:11 +09:00
committed by GitHub
parent a553fda32b
commit 7c50164987
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
scripts/build-jsc.ts
View File

@@ -129,6 +129,7 @@ const getCommonFlags = (config: BuildConfig) => {
"-DBUN_FAST_TLS=ON", "-DBUN_FAST_TLS=ON",
"-DPTHREAD_JIT_PERMISSIONS_API=1", "-DPTHREAD_JIT_PERMISSIONS_API=1",
"-DUSE_PTHREAD_JIT_PERMISSIONS_API=ON", "-DUSE_PTHREAD_JIT_PERMISSIONS_API=ON",
"-DENABLE_REMOTE_INSPECTOR=ON",
); );
} else if (IS_LINUX) { } else if (IS_LINUX) {
flags.push( flags.push(
@@ -172,7 +173,6 @@ const getBuildFlags = (config: BuildConfig) => {
"-DCMAKE_BUILD_TYPE=Debug", "-DCMAKE_BUILD_TYPE=Debug",
"-DENABLE_BUN_SKIP_FAILING_ASSERTIONS=ON", "-DENABLE_BUN_SKIP_FAILING_ASSERTIONS=ON",
"-DCMAKE_EXPORT_COMPILE_COMMANDS=ON", "-DCMAKE_EXPORT_COMPILE_COMMANDS=ON",
"-DENABLE_REMOTE_INSPECTOR=ON",
"-DUSE_VISIBILITY_ATTRIBUTE=1", "-DUSE_VISIBILITY_ATTRIBUTE=1",
); );