From 7d58787ddacf68615ed9325990c0efd6d55a9dbf Mon Sep 17 00:00:00 2001 From: Jarred Sumner Date: Tue, 7 Jan 2025 18:01:28 -0800 Subject: [PATCH] Module.findSourceMap shouldn't throw (#16229) --- src/bun.js/modules/NodeModuleModule.cpp | 8 +------- test/js/node/module/node-module-module.test.js | 4 ++++ 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/bun.js/modules/NodeModuleModule.cpp b/src/bun.js/modules/NodeModuleModule.cpp index e913e937b9..b3973e7eaf 100644 --- a/src/bun.js/modules/NodeModuleModule.cpp +++ b/src/bun.js/modules/NodeModuleModule.cpp @@ -284,13 +284,7 @@ JSC_DEFINE_HOST_FUNCTION(jsFunctionFindSourceMap, (JSGlobalObject * globalObject, CallFrame* callFrame)) { - auto& vm = globalObject->vm(); - auto scope = DECLARE_THROW_SCOPE(vm); - throwException( - globalObject, scope, - createError(globalObject, - "module.SourceMap is not yet implemented in Bun"_s)); - return {}; + return JSValue::encode(jsUndefined()); } JSC_DEFINE_HOST_FUNCTION(jsFunctionSyncBuiltinExports, diff --git a/test/js/node/module/node-module-module.test.js b/test/js/node/module/node-module-module.test.js index 9c44c9656e..ca76ce322a 100644 --- a/test/js/node/module/node-module-module.test.js +++ b/test/js/node/module/node-module-module.test.js @@ -135,3 +135,7 @@ test("Module._resolveLookupPaths", () => { expect(Module._resolveLookupPaths("./bar", { paths: ["a"] })).toEqual(["."]); expect(Module._resolveLookupPaths("bar", { paths: ["a"] })).toEqual(["a"]); }); + +test("Module.findSourceMap doesn't throw", () => { + expect(Module.findSourceMap("foo")).toEqual(undefined); +});