mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-13 20:39:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: require.extensions uses Strong instead of being clever (#19231)

Browse Source
This commit is contained in:
chloe caruso
2025-04-23 17:52:41 -07:00
committed by GitHub
parent 1294128b47
commit 80aff24951
41 changed files with 254 additions and 315 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/bun.js/ModuleLoader.zig
View File

@@ -69,7 +69,7 @@ pub fn resolveEmbeddedFile(vm: *VirtualMachine, input_path: []const u8, extname:
pub const AsyncModule = struct {
// This is all the state used by the printer to print the module
parse_result: ParseResult,
promise: JSC.Strong = .empty,
promise: JSC.Strong.Optional = .empty,
path: Fs.Path,
specifier: string = "",
referrer: string = "",
@@ -376,7 +376,7 @@ pub const AsyncModule = struct {
// var stmt_blocks = js_ast.Stmt.Data.toOwnedSlice();
// var expr_blocks = js_ast.Expr.Data.toOwnedSlice();
const this_promise = JSValue.createInternalPromise(globalObject);
const promise = JSC.Strong.create(this_promise, globalObject);
const promise = JSC.Strong.Optional.create(this_promise, globalObject);
var buf = bun.StringBuilder{};
buf.count(opts.referrer);
@@ -1625,13 +1625,13 @@ pub export fn Bun__transpileFile(
.loader => |loader| {
lr.loader = loader;
},
.custom => |index| {
.custom => |strong| {
ret.* = JSC.ErrorableResolvedSource.ok(ResolvedSource{
.allocator = null,
.source_code = bun.String.empty,
.specifier = .empty,
.source_url = .empty,
.cjs_custom_extension_index = index,
.cjs_custom_extension_index = strong.get(),
.tag = .common_js_custom_extension,
});
return null;
@@ -1750,13 +1750,13 @@ pub export fn Bun__transpileFile(
if (node_module_module.findLongestRegisteredExtension(jsc_vm, lr.path.text)) |entry| {
switch (entry) {
.loader => |loader| break :loader loader,
.custom => |index| {
.custom => |strong| {
ret.* = JSC.ErrorableResolvedSource.ok(ResolvedSource{
.allocator = null,
.source_code = bun.String.empty,
.specifier = .empty,
.source_url = .empty,
.cjs_custom_extension_index = index,
.cjs_custom_extension_index = strong.get(),
.tag = .common_js_custom_extension,
});
return null;
@@ -2191,7 +2191,7 @@ pub const RuntimeTranspilerStore = struct {
.vm = vm,
.log = logger.Log.init(bun.default_allocator),
.loader = loader,
.promise = JSC.Strong.create(JSValue.fromCell(promise), globalObject),
.promise = .create(JSValue.fromCell(promise), globalObject),
.poll_ref = .{},
.fetcher = TranspilerJob.Fetcher{
.file = {},
@@ -2209,7 +2209,7 @@ pub const RuntimeTranspilerStore = struct {
non_threadsafe_input_specifier: String,
non_threadsafe_referrer: String,
loader: options.Loader,
promise: JSC.Strong = .empty,
promise: JSC.Strong.Optional = .empty,
vm: *VirtualMachine,
globalThis: *JSGlobalObject,
fetcher: Fetcher,