mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-14 04:49:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix PostgreSQL bulk insert panic with proper overflow handling

Browse Source 
Previously, when a bulk insert operation exceeded the PostgreSQL
protocol's 2GB message size limit, Bun would panic with "integer
does not fit in destination type". This typically occurred with
around 8,150+ items depending on row size.

This change:
- Adds a new specific error.MessageTooLarge to the error set
- Checks message size before casting to i32 in NewWriter.zig
- Returns ERR_POSTGRES_MESSAGE_TOO_LARGE with a clear, actionable message
- Keeps error.Overflow generic for future numeric overflow cases

The error message now clearly explains:
"Query message exceeds PostgreSQL protocol limit of 2GB. Try reducing
the number of rows in your bulk insert or split it into smaller batches."

Fixes #24640

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Claude Bot
2025-11-12 14:52:17 +00:00
parent 0a307ed880
commit 840143f6ca
3 changed files with 86 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/sql/postgres/AnyPostgresError.zig
View File

@@ -15,6 +15,7 @@ pub const AnyPostgresError = error{
InvalidTimeFormat,
JSError,
JSTerminated,
MessageTooLarge,
MultidimensionalArrayNotSupportedYet,
NullsInArrayNotSupportedYet,
OutOfMemory,
@@ -93,6 +94,7 @@ pub fn postgresErrorToJS(globalObject: *jsc.JSGlobalObject, message: ?[]const u8
error.InvalidServerKey => "ERR_POSTGRES_INVALID_SERVER_KEY",
error.InvalidServerSignature => "ERR_POSTGRES_INVALID_SERVER_SIGNATURE",
error.InvalidTimeFormat => "ERR_POSTGRES_INVALID_TIME_FORMAT",
error.MessageTooLarge => "ERR_POSTGRES_MESSAGE_TOO_LARGE",
error.MultidimensionalArrayNotSupportedYet => "ERR_POSTGRES_MULTIDIMENSIONAL_ARRAY_NOT_SUPPORTED_YET",
error.NullsInArrayNotSupportedYet => "ERR_POSTGRES_NULLS_IN_ARRAY_NOT_SUPPORTED_YET",
error.Overflow => "ERR_POSTGRES_OVERFLOW",
@@ -124,8 +126,11 @@ pub fn postgresErrorToJS(globalObject: *jsc.JSGlobalObject, message: ?[]const u8
},
};
var buffer_message = [_]u8{0} ** 256;
const msg = message orelse std.fmt.bufPrint(buffer_message[0..], "Failed to bind query: {s}", .{@errorName(err)}) catch "Failed to bind query";
var buffer_message = [_]u8{0} ** 512;
const msg = message orelse switch (err) {
error.MessageTooLarge => "Query message exceeds PostgreSQL protocol limit of 2GB. Try reducing the number of rows in your bulk insert or split it into smaller batches.",
else => std.fmt.bufPrint(&buffer_message, "Failed to bind query: {s}", .{@errorName(err)}) catch "Failed to bind query",
};
return createPostgresError(globalObject, msg, .{ .code = code }) catch |e| globalObject.takeError(e);
}