From 87df7527bbe6b58dfb714c3fc073bd2bdd9d4027 Mon Sep 17 00:00:00 2001 From: Meghan Denny Date: Thu, 24 Jul 2025 12:44:55 -0800 Subject: [PATCH] node: fix test-http-url.parse-https.request.js (#21335) --- .../test-http-url.parse-https.request.js | 61 +++++++++++++++++++ 1 file changed, 61 insertions(+) create mode 100644 test/js/node/test/parallel/test-http-url.parse-https.request.js diff --git a/test/js/node/test/parallel/test-http-url.parse-https.request.js b/test/js/node/test/parallel/test-http-url.parse-https.request.js new file mode 100644 index 0000000000..2f18899176 --- /dev/null +++ b/test/js/node/test/parallel/test-http-url.parse-https.request.js @@ -0,0 +1,61 @@ +// Copyright Joyent, Inc. and other Node contributors. +// +// Permission is hereby granted, free of charge, to any person obtaining a +// copy of this software and associated documentation files (the +// "Software"), to deal in the Software without restriction, including +// without limitation the rights to use, copy, modify, merge, publish, +// distribute, sublicense, and/or sell copies of the Software, and to permit +// persons to whom the Software is furnished to do so, subject to the +// following conditions: +// +// The above copyright notice and this permission notice shall be included +// in all copies or substantial portions of the Software. +// +// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS +// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF +// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN +// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, +// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR +// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE +// USE OR OTHER DEALINGS IN THE SOFTWARE. + +'use strict'; +const common = require('../common'); +if (!common.hasCrypto) + common.skip('missing crypto'); +const { readKey } = require('../common/fixtures'); + +const assert = require('assert'); +const https = require('https'); +const url = require('url'); + +// https options +const httpsOptions = { + key: readKey('agent1-key.pem'), + cert: readKey('agent1-cert.pem') +}; + +function check(request) { + // Assert that I'm https + assert.ok(request.socket._secureEstablished); +} + +const server = https.createServer(httpsOptions, function(request, response) { + // Run the check function + check(request); + response.writeHead(200, {}); + response.end('ok'); + server.close(); +}); + +server.listen(0, function() { + const testURL = url.parse(`https://localhost:${this.address().port}`); + testURL.rejectUnauthorized = false; + + // make the request + const clientRequest = https.request(testURL); + // Since there is a little magic with the agent + // make sure that the request uses the https.Agent + assert.ok(clientRequest.agent instanceof https.Agent); + clientRequest.end(); +});