From 8b17029b06ef13ca534fb4cc0969cfba268e1dd3 Mon Sep 17 00:00:00 2001 From: Meghan Denny Date: Fri, 13 Dec 2024 22:43:03 -0800 Subject: [PATCH] dont create JSString for ASCIILiteral --- src/bun.js/bindings/NodeValidator.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/bun.js/bindings/NodeValidator.cpp b/src/bun.js/bindings/NodeValidator.cpp index 0f4c9d81b2..6ac04baba0 100644 --- a/src/bun.js/bindings/NodeValidator.cpp +++ b/src/bun.js/bindings/NodeValidator.cpp @@ -518,11 +518,10 @@ JSC_DEFINE_HOST_FUNCTION(jsFunction_validateBuffer, (JSC::JSGlobalObject * globa auto name = callFrame->argument(1); return V::validateBuffer(scope, globalObject, buffer, name); } -JSC::EncodedJSValue V::validateBuffer(JSC::ThrowScope& scope, JSC::JSGlobalObject* globalObject, JSValue buffer, JSValue name) +JSC::EncodedJSValue V::validateBuffer(JSC::ThrowScope& scope, JSC::JSGlobalObject* globalObject, JSValue buffer, JSValue nameValue) { - JSC::VM& vm = globalObject->vm(); - - if (name.isUndefined()) name = jsString(vm, String("buffer"_s)); + auto name = nameValue.isUndefined() ? "buffer"_s : nameValue.toWTFString(globalObject); + RETURN_IF_EXCEPTION(scope, {}); if (!buffer.isCell()) return JSValue::encode(jsUndefined()); auto ty = buffer.asCell()->type();