From 8efcc61a7b5fdc273b5ccd6f26a391c76f4f31bb Mon Sep 17 00:00:00 2001 From: Meghan Denny Date: Mon, 29 Jul 2024 19:16:02 -0700 Subject: [PATCH] windows: cleanup logging of NODE_CHANNEL_FD (#12930) --- src/bun.js/javascript.zig | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/bun.js/javascript.zig b/src/bun.js/javascript.zig index eff41e2c3f..c783385a40 100644 --- a/src/bun.js/javascript.zig +++ b/src/bun.js/javascript.zig @@ -990,18 +990,20 @@ pub const VirtualMachine = struct { } if (map.map.fetchSwapRemove("NODE_CHANNEL_FD")) |kv| { + const fd_s = kv.value.value; const mode = if (map.map.fetchSwapRemove("NODE_CHANNEL_SERIALIZATION_MODE")) |mode_kv| IPC.Mode.fromString(mode_kv.value.value) orelse .json else .json; - IPC.log("IPC environment variables: NODE_CHANNEL_FD={d}, NODE_CHANNEL_SERIALIZATION_MODE={s}", .{ kv.value.value, @tagName(mode) }); if (Environment.isWindows) { - this.initIPCInstance(kv.value.value, mode); + IPC.log("IPC environment variables: NODE_CHANNEL_FD={s}, NODE_CHANNEL_SERIALIZATION_MODE={s}", .{ fd_s, @tagName(mode) }); + this.initIPCInstance(fd_s, mode); } else { - if (std.fmt.parseInt(i32, kv.value.value, 10)) |fd| { + IPC.log("IPC environment variables: NODE_CHANNEL_FD={d}, NODE_CHANNEL_SERIALIZATION_MODE={s}", .{ fd_s, @tagName(mode) }); + if (std.fmt.parseInt(i32, fd_s, 10)) |fd| { this.initIPCInstance(bun.toFD(fd), mode); } else |_| { - Output.warn("Failed to parse IPC channel number '{s}'", .{kv.value.value}); + Output.warn("Failed to parse IPC channel number '{s}'", .{fd_s}); } } }