diff --git a/Makefile b/Makefile index eb22ddb61c..1195d12a70 100644 --- a/Makefile +++ b/Makefile @@ -673,7 +673,7 @@ assert-deps: @echo "You have the dependencies installed! Woo" # the following allows you to run `make submodule` to update or init submodules. but we will exclude webkit -# unless you explicity clone it yourself (a huge download) +# unless you explicitly clone it yourself (a huge download) SUBMODULE_NAMES=$(shell cat .gitmodules | grep 'path = ' | awk '{print $$3}') ifeq ("$(wildcard src/bun.js/WebKit/.git)", "") SUBMODULE_NAMES := $(filter-out src/bun.js/WebKit, $(SUBMODULE_NAMES)) diff --git a/scripts/update-submodules.ps1 b/scripts/update-submodules.ps1 index 39b1853d89..dff2fb292e 100755 --- a/scripts/update-submodules.ps1 +++ b/scripts/update-submodules.ps1 @@ -8,7 +8,7 @@ Push-Location (Join-Path $ScriptDir '..') try { $Names = Get-Content .gitmodules | Select-String 'path = (.*)' | ForEach-Object { $_.Matches.Groups[1].Value } - # we will exclude webkit unless you explicity clone it yourself (a huge download) + # we will exclude webkit unless you explicitly clone it yourself (a huge download) if (!($WebKit) -and (-not (Test-Path "src/bun.js/WebKit/.git"))) { $Names = $Names | Where-Object { $_ -ne 'src/bun.js/WebKit' } } diff --git a/scripts/update-submodules.sh b/scripts/update-submodules.sh index 70994efaa1..82cd63b23e 100755 --- a/scripts/update-submodules.sh +++ b/scripts/update-submodules.sh @@ -4,7 +4,7 @@ cd .. NAMES=$(cat .gitmodules | grep 'path = ' | awk '{print $3}') if ! [ "$1" == '--webkit' ]; then - # we will exclude webkit unless you explicity clone it yourself (a huge download) + # we will exclude webkit unless you explicitly clone it yourself (a huge download) if [ ! -e "src/bun.js/WebKit/.git" ]; then NAMES=$(echo "$NAMES" | grep -v 'WebKit') fi diff --git a/src/bun.js/bindings/CommonJSModuleRecord.cpp b/src/bun.js/bindings/CommonJSModuleRecord.cpp index c85feff505..7f5201c269 100644 --- a/src/bun.js/bindings/CommonJSModuleRecord.cpp +++ b/src/bun.js/bindings/CommonJSModuleRecord.cpp @@ -662,7 +662,7 @@ bool JSCommonJSModule::evaluate( auto throwScope = DECLARE_THROW_SCOPE(vm); generator(globalObject, JSC::Identifier::fromString(vm, key), propertyNames, arguments); RETURN_IF_EXCEPTION(throwScope, false); - // This goes off of the assumption that you only call this `evaluate` using a generator that explicity + // This goes off of the assumption that you only call this `evaluate` using a generator that explicitly // assigns the `default` export first. JSValue defaultValue = arguments.at(0); this->putDirect(vm, WebCore::clientData(vm)->builtinNames().exportsPublicName(), defaultValue, 0); diff --git a/test/bundler/expectBundled.md b/test/bundler/expectBundled.md index 299c31cacf..45014cdc94 100644 --- a/test/bundler/expectBundled.md +++ b/test/bundler/expectBundled.md @@ -10,7 +10,7 @@ Call `expectBundled` within a test to test the bundler. The `id` passed as the f All bundle entry files, their outputs, and other helpful files are written to disk at: `$TEMP/bun-build-tests/{run_id}/{id}`. This can be used to inspect and debug bundles, as they are not deleted after runtime. -In addition to comparing the bundle outputs against snapshots, **most test cases execute the bundle and have additional checks to assert the intended logic is happening properly**. This allows the bundler to change exactly how it writes files (optimizations / variable renaming), and still have concrete tests that ensure what the bundler creates will function properly. Snapshots are also taken, but these are used to check for regressions and not neccessarily check accuracy. +In addition to comparing the bundle outputs against snapshots, **most test cases execute the bundle and have additional checks to assert the intended logic is happening properly**. This allows the bundler to change exactly how it writes files (optimizations / variable renaming), and still have concrete tests that ensure what the bundler creates will function properly. Snapshots are also taken, but these are used to check for regressions and not necessarily check accuracy. On top of `expectBundled`, there is also `itBundled` which wraps `expectBundled` and `it` together, which is what we mostly use in our tests. diff --git a/test/bundler/expectBundled.ts b/test/bundler/expectBundled.ts index ad09d87bc2..6ccb28ea81 100644 --- a/test/bundler/expectBundled.ts +++ b/test/bundler/expectBundled.ts @@ -376,7 +376,7 @@ function expectBundled( // TODO: Remove this check once all options have been implemented if (Object.keys(unknownProps).length > 0) { - throw new Error("expectBundled recieved unexpected options: " + Object.keys(unknownProps).join(", ")); + throw new Error("expectBundled received unexpected options: " + Object.keys(unknownProps).join(", ")); } // This is a sanity check that protects against bad copy pasting. @@ -1236,7 +1236,7 @@ for (const [key, blob] of build.outputs) { if (run.errorLineMatch) { // in order to properly analyze the error, we have to look backwards on stderr. this approach - // most definetly can be improved but it works fine here. + // most definitely can be improved but it works fine here. const stack = []; let error; const lines = stderr!