From 93a5c2632719fc4d89eae84ed4c19b588d264fcd Mon Sep 17 00:00:00 2001 From: Claude Bot Date: Mon, 3 Nov 2025 10:23:23 +0000 Subject: [PATCH] Address code review feedback for process.threadCpuUsage MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Change #ifdef to #if defined(RUSAGE_THREAD) for consistency - Update hardcoded libuv version from 1.48.0 to 1.51.0 to match vendored version This ensures process.versions.uv correctly reports 1.51.0, which is the actual version bundled in vendor/node/deps/uv that includes uv_getrusage_thread (added in libuv 1.50.0). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- src/bun.js/bindings/BunProcess.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/bun.js/bindings/BunProcess.cpp b/src/bun.js/bindings/BunProcess.cpp index b0b04aa05b..abc1078e72 100644 --- a/src/bun.js/bindings/BunProcess.cpp +++ b/src/bun.js/bindings/BunProcess.cpp @@ -232,7 +232,7 @@ static JSValue constructVersions(VM& vm, JSObject* processObject) #if OS(WINDOWS) object->putDirect(vm, JSC::Identifier::fromString(vm, "uv"_s), JSValue(JSC::jsOwnedString(vm, String::fromLatin1(uv_version_string()))), 0); #else - object->putDirect(vm, JSC::Identifier::fromString(vm, "uv"_s), JSValue(JSC::jsOwnedString(vm, String("1.48.0"_s))), 0); + object->putDirect(vm, JSC::Identifier::fromString(vm, "uv"_s), JSValue(JSC::jsOwnedString(vm, String("1.51.0"_s))), 0); #endif object->putDirect(vm, JSC::Identifier::fromString(vm, "napi"_s), JSValue(JSC::jsOwnedString(vm, String("10"_s))), 0); @@ -3161,7 +3161,7 @@ JSC_DEFINE_HOST_FUNCTION(Process_functionThreadCpuUsage, (JSC::JSGlobalObject * #elif OS(LINUX) struct rusage rusage; -#ifdef RUSAGE_THREAD +#if defined(RUSAGE_THREAD) int status = getrusage(RUSAGE_THREAD, &rusage); #elifdef RUSAGE_LWP int status = getrusage(RUSAGE_LWP, &rusage);