From 9b735b6e729ac2482247f79ea89c98a4e960ceae Mon Sep 17 00:00:00 2001 From: Claude Bot Date: Sat, 17 Jan 2026 09:39:23 +0000 Subject: [PATCH] fix(ci): rename BUILD_TYPE to BUILD_DIR for clarity The variable is only used as a directory name, not passed to CMake. Renaming to BUILD_DIR makes its purpose clear and avoids confusion with CMake's CMAKE_BUILD_TYPE. Co-Authored-By: Claude Opus 4.5 --- scripts/bake-dependencies.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/bake-dependencies.sh b/scripts/bake-dependencies.sh index 3c97ce094f..23651e543f 100755 --- a/scripts/bake-dependencies.sh +++ b/scripts/bake-dependencies.sh @@ -60,13 +60,13 @@ ABI="$(detect_abi)" # Default paths - these should match what the buildkite agent uses BUN_REPO_PATH="${BUN_REPO_PATH:-/var/lib/buildkite-agent/build}" -BUILD_TYPE="${BUILD_TYPE:-release}" +BUILD_DIR="${BUILD_DIR:-release}" print "=== Bun Dependency Baking Script ===" print "Architecture: $ARCH" print "ABI: ${ABI:-glibc}" print "Repository path: $BUN_REPO_PATH" -print "Build type: $BUILD_TYPE" +print "Build directory: $BUILD_DIR" # Clone the Bun repository if it doesn't exist if [ ! -d "$BUN_REPO_PATH/.git" ]; then @@ -90,7 +90,7 @@ print "Generating cmake source lists..." bun run scripts/glob-sources.mjs # Set up build directory -BUILD_PATH="$BUN_REPO_PATH/build/$BUILD_TYPE" +BUILD_PATH="$BUN_REPO_PATH/build/$BUILD_DIR" CACHE_PATH="$BUILD_PATH/cache" mkdir -p "$BUILD_PATH" "$CACHE_PATH"