From a2ba9cbd994a936dbd0bc4ee91c3b6a4e369a8c4 Mon Sep 17 00:00:00 2001 From: Claude Bot Date: Mon, 2 Feb 2026 22:59:23 +0000 Subject: [PATCH] fix: address review comments - Add disable_sigusr1 to bootStandalone options so standalone executables respect the --disable-sigusr1 flag - Replace inline snapshot with explicit toBe() for clearer output comparison Co-Authored-By: Claude Opus 4.5 --- src/bun.js.zig | 1 + .../runtime-inspector-posix.test.ts | 12 +++++------- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/src/bun.js.zig b/src/bun.js.zig index daa39f847f..b0a382fa21 100644 --- a/src/bun.js.zig +++ b/src/bun.js.zig @@ -38,6 +38,7 @@ pub const Run = struct { .smol = ctx.runtime_options.smol, .debugger = ctx.runtime_options.debugger, .dns_result_order = DNSResolver.Order.fromStringOrDie(ctx.runtime_options.dns_result_order), + .disable_sigusr1 = ctx.runtime_options.disable_sigusr1, }), .arena = arena, .ctx = ctx, diff --git a/test/js/bun/runtime-inspector/runtime-inspector-posix.test.ts b/test/js/bun/runtime-inspector/runtime-inspector-posix.test.ts index 9445114015..8693b50aa2 100644 --- a/test/js/bun/runtime-inspector/runtime-inspector-posix.test.ts +++ b/test/js/bun/runtime-inspector/runtime-inspector-posix.test.ts @@ -188,13 +188,11 @@ describe.skipIf(isWindows)("Runtime inspector SIGUSR1 activation", () => { const [stderr, exitCode] = await Promise.all([proc.stderr.text(), proc.exited]); - expect(output).toMatchInlineSnapshot(` - "READY - SIGNAL_1 - SIGNAL_2 - SIGNAL_3 - " - `); + expect(output).toBe(`READY +SIGNAL_1 +SIGNAL_2 +SIGNAL_3 +`); expect(stderr).not.toContain("Bun Inspector"); expect(exitCode).toBe(0); });