mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-19 07:12:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename non-refing Bun::toString overloads to Bun::toStringNonRef

Browse Source
This commit is contained in:
Ben Grant
2025-03-25 16:39:02 -07:00
parent 57381d43ed
commit a7bb4d7cb1
18 changed files with 59 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/bun.js/bindings/JSCommonJSModule.cpp
View File

@@ -1151,8 +1151,8 @@ JSC_DEFINE_HOST_FUNCTION(jsFunctionRequireCommonJS, (JSGlobalObject * lexicalGlo
// This is always a new JSCommonJSModule object; cast cannot fail.
JSCommonJSModule* child = jsCast<JSCommonJSModule*>(callframe->uncheckedArgument(1));
BunString specifierStr = Bun::toString(specifier);
BunString referrerStr = Bun::toString(referrer);
BunString specifierStr = Bun::toStringNonRef(specifier);
BunString referrerStr = Bun::toStringNonRef(referrer);
BunString typeAttributeStr = { BunStringTag::Dead };
String typeAttribute = String();
@@ -1170,7 +1170,7 @@ JSC_DEFINE_HOST_FUNCTION(jsFunctionRequireCommonJS, (JSGlobalObject * lexicalGlo
if (typeValue.isString()) {
typeAttribute = typeValue.toWTFString(globalObject);
RETURN_IF_EXCEPTION(throwScope, {});
typeAttributeStr = Bun::toString(typeAttribute);
typeAttributeStr = Bun::toStringNonRef(typeAttribute);
}
}
RETURN_IF_EXCEPTION(throwScope, {});
@@ -1217,7 +1217,7 @@ JSC_DEFINE_HOST_FUNCTION(jsFunctionRequireNativeModule, (JSGlobalObject * lexica
WTF::String specifier = specifierValue.toWTFString(globalObject);
RETURN_IF_EXCEPTION(throwScope, {});
ErrorableResolvedSource res;
BunString specifierStr = Bun::toString(specifier);
BunString specifierStr = Bun::toStringNonRef(specifier);
if (auto result = fetchBuiltinModuleWithoutResolution(globalObject, &specifierStr, &res)) {
if (res.success)
return JSC::JSValue::encode(result);