From a8ff7be642a3cd93e033b324cfd1fc966b69af12 Mon Sep 17 00:00:00 2001 From: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com> Date: Sun, 21 Jan 2024 06:10:07 -0800 Subject: [PATCH] Disable Bun.stringWidth until failing test case passes --- src/bun.js/bindings/BunObject.cpp | 1 - test/js/bun/util/stringWidth.test.ts | 8 ++++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/bun.js/bindings/BunObject.cpp b/src/bun.js/bindings/BunObject.cpp index 91e412de10..5a8958925f 100644 --- a/src/bun.js/bindings/BunObject.cpp +++ b/src/bun.js/bindings/BunObject.cpp @@ -621,7 +621,6 @@ JSC_DEFINE_HOST_FUNCTION(functionHashCode, stdin BunObject_getter_wrap_stdin DontDelete|PropertyCallback stdout BunObject_getter_wrap_stdout DontDelete|PropertyCallback stringHashCode functionHashCode DontDelete|Function 1 - stringWidth BunObject_callback_stringWidth DontDelete|Function 2 unsafe BunObject_getter_wrap_unsafe DontDelete|PropertyCallback version constructBunVersion ReadOnly|DontDelete|PropertyCallback which BunObject_callback_which DontDelete|Function 1 diff --git a/test/js/bun/util/stringWidth.test.ts b/test/js/bun/util/stringWidth.test.ts index a58fa7b694..0d1252e1fb 100644 --- a/test/js/bun/util/stringWidth.test.ts +++ b/test/js/bun/util/stringWidth.test.ts @@ -83,3 +83,11 @@ for (let matcher of ["toMatchNPMStringWidth", "toMatchNPMStringWidthExcludeANSI" }); }); } + +for (let matcher of ["toMatchNPMStringWidth", "toMatchNPMStringWidthExcludeANSI"]) { + test.todo("leading non-ansi characters in UTF-16 string seems to fail", () => { + expect("\x1b[31mhshh🌎")[matcher](); + expect("a\x1b[31mhshh🌎")[matcher](); + expect("a\x1b[31mhshh🌎a")[matcher](); + }); +}