From a9d23f190898fc5da677d9b79765ea32558b34cc Mon Sep 17 00:00:00 2001 From: Ciro Spaciari Date: Wed, 21 May 2025 16:24:08 -0700 Subject: [PATCH] more --- src/js/node/http2.ts | 2 +- .../test/parallel/test-http2-cancel-while-client-reading.js | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/js/node/http2.ts b/src/js/node/http2.ts index 4b9b53f738..d5ac90e439 100644 --- a/src/js/node/http2.ts +++ b/src/js/node/http2.ts @@ -1891,7 +1891,7 @@ class Http2Stream extends Duplex { } markStreamClosed(this); this.rstCode = code; - if (this.writableFinished) { + if (this.writableFinished || code) { setImmediate(rstNextTick.bind(session, this.#id, code)); } else { this.once("finish", rstNextTick.bind(session, this.#id, code)); diff --git a/test/js/node/test/parallel/test-http2-cancel-while-client-reading.js b/test/js/node/test/parallel/test-http2-cancel-while-client-reading.js index 4f4531004d..2011a6e2b2 100644 --- a/test/js/node/test/parallel/test-http2-cancel-while-client-reading.js +++ b/test/js/node/test/parallel/test-http2-cancel-while-client-reading.js @@ -28,6 +28,7 @@ server.listen(0, function() { { rejectUnauthorized: false } ); client_stream = client.request({ ':method': 'POST' }); + client_stream.on('close', common.mustCall(() => { client.close(); server.close();