From b3bfede9306750837db82da458399d5f99a0751b Mon Sep 17 00:00:00 2001 From: Ben Grant Date: Tue, 25 Mar 2025 16:53:45 -0700 Subject: [PATCH] Delete unnecessary overloads --- src/bun.js/bindings/BunString.cpp | 15 --------------- src/bun.js/bindings/headers-handwritten.h | 2 -- 2 files changed, 17 deletions(-) diff --git a/src/bun.js/bindings/BunString.cpp b/src/bun.js/bindings/BunString.cpp index 359106a470..5cbc5a51ce 100644 --- a/src/bun.js/bindings/BunString.cpp +++ b/src/bun.js/bindings/BunString.cpp @@ -224,13 +224,6 @@ BunString toStringRef(JSC::JSGlobalObject* globalObject, JSValue value) return { BunStringTag::WTFStringImpl, { .wtf = impl } }; } -BunString toStringNonRef(WTF::String& wtfString) -{ - if (wtfString.isEmpty()) - return { BunStringTag::Empty }; - - return { BunStringTag::WTFStringImpl, { .wtf = wtfString.impl() } }; -} BunString toStringNonRef(const WTF::String& wtfString) { if (wtfString.isEmpty()) @@ -246,14 +239,6 @@ BunString toStringNonRef(WTF::StringImpl* wtfString) return { BunStringTag::WTFStringImpl, { .wtf = wtfString } }; } -BunString toStringRef(WTF::String& wtfString) -{ - if (wtfString.isEmpty()) - return { BunStringTag::Empty }; - - wtfString.impl()->ref(); - return { BunStringTag::WTFStringImpl, { .wtf = wtfString.impl() } }; -} BunString toStringRef(const WTF::String& wtfString) { if (wtfString.isEmpty()) diff --git a/src/bun.js/bindings/headers-handwritten.h b/src/bun.js/bindings/headers-handwritten.h index 682decad30..837ab8b1bf 100644 --- a/src/bun.js/bindings/headers-handwritten.h +++ b/src/bun.js/bindings/headers-handwritten.h @@ -299,14 +299,12 @@ BunString toString(const char* bytes, size_t length); // the same lifetime as the argument. Be very careful that the BunString is not used after the // WTF::String has gone out of scope. BunString toStringNonRef(JSC::JSGlobalObject* globalObject, JSC::JSValue value); -BunString toStringNonRef(WTF::String& wtfString); BunString toStringNonRef(const WTF::String& wtfString); BunString toStringNonRef(WTF::StringImpl* wtfString); // These functions increment the reference count on their argument. `deref` must be called later // on the return value to avoid a leak. BunString toStringRef(JSC::JSGlobalObject* globalObject, JSC::JSValue value); -BunString toStringRef(WTF::String& wtfString); BunString toStringRef(const WTF::String& wtfString); BunString toStringRef(WTF::StringImpl* wtfString);