From b9ceca7e30e6950eeb9546e7ff6967c2f32056c2 Mon Sep 17 00:00:00 2001
From: Jarred Sumner <jarred@jarredsumner.com>
Date: Tue, 5 Mar 2024 22:03:42 -0800
Subject: [PATCH] fixups

---
 src/bun.js/api/bun/process.zig  | 13 ++++++-------
 test/js/bun/spawn/spawn.test.ts | 10 ++++++----
 2 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/src/bun.js/api/bun/process.zig b/src/bun.js/api/bun/process.zig
index afd17d9bf0..17db21b198 100644
--- a/src/bun.js/api/bun/process.zig
+++ b/src/bun.js/api/bun/process.zig
@@ -611,19 +611,18 @@ pub const PollerWindows = union(enum) {
     }
 
     pub fn disableKeepingEventLoopAlive(this: *PollerWindows, event_loop: JSC.EventLoopHandle) void {
-        _ = this; // autofix
         _ = event_loop; // autofix
 
         // This is disabled on Windows
         // uv_unref() causes the onExitUV callback to *never* be called
         // This breaks a lot of stuff...
         // Once fixed, re-enable "should not hang after unref" test in spawn.test
-        // switch (this.*) {
-        //     .uv => |*process| {
-        //         // process.unref();
-        //     },
-        //     else => {},
-        // }
+        switch (this.*) {
+            .uv => {
+                this.uv.unref();
+            },
+            else => {},
+        }
     }
 
     pub fn hasRef(this: *const PollerWindows) bool {
diff --git a/test/js/bun/spawn/spawn.test.ts b/test/js/bun/spawn/spawn.test.ts
index 86b4c771b1..d0a796f533 100644
--- a/test/js/bun/spawn/spawn.test.ts
+++ b/test/js/bun/spawn/spawn.test.ts
@@ -531,7 +531,8 @@ describe("spawn unref and kill should not hang", () => {
         stderr: "ignore",
         stdin: "ignore",
       });
-      proc.unref();
+      // TODO: on Windows
+      if (!isWindows) proc.unref();
       await proc.exited;
     }
 
@@ -546,7 +547,7 @@ describe("spawn unref and kill should not hang", () => {
         stdin: "ignore",
       });
 
-      // proc.kill();
+      proc.kill();
       proc.unref();
       await Bun.sleep(100);
       await proc.exited;
@@ -564,7 +565,8 @@ describe("spawn unref and kill should not hang", () => {
         stderr: "ignore",
         stdin: "ignore",
       });
-      proc.unref();
+      // TODO: on Windows
+      if (!isWindows) proc.unref();
       proc.kill();
       await proc.exited;
     }
@@ -573,7 +575,7 @@ describe("spawn unref and kill should not hang", () => {
   });
 
   // process.unref() on Windows does not work ye :(
-  it.skipIf(isWindows)("should not hang after unref", async () => {
+  it("should not hang after unref", async () => {
     const proc = spawn({
       cmd: [bunExe(), path.join(import.meta.dir, "does-not-hang.js")],
     });