From ba12a3dfd42a37137fdc922028e5d98682d5a02c Mon Sep 17 00:00:00 2001 From: pfg Date: Tue, 3 Jun 2025 15:34:29 -0700 Subject: [PATCH] problm --- categories.txt | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/categories.txt b/categories.txt index c0a092f93c..6db3474fdc 100644 --- a/categories.txt +++ b/categories.txt @@ -81,6 +81,19 @@ test-tls-secure-session.js - client.on("session") never called? - probably because it sets secureProtocol: 'TLSv1_2_method' - we probably don't support setting secureProtocol +- we don't emit a session event at all ever except in http2. node emits a session at the end of onConnectSecure and in onnewesssionclient +- search terms: 'emit('session)' + +desc + +test-tls-secure-session is failing for two reasions: +1. Bun doesn't implement secureProtocol, so it does not use tls v1.2 +2. Bun does not emit a session event. + +Tasks. Complete tasks one at a time. Once a task is completed and tested, check off the task and commit your code. +- [ ] Create a test file called `repro.js` that tests if the session event is emitted. Make sure it passes using `node repro.js` and fails using `bun bd repro.js` +- [ ] Search node's source code (in ../node) and find when it emits a sesssion event, then update Bun's code to emit a session event the same way. Test if this worked using `bun bd repro.js` +- [ ] Implement secureProtocol. Test if this worked using `bun bd test/js/node/test/parallel/test-tls-secure-session.js`. It will time out if it fails. test-tls-js-stream.js: - connection closes earlier than expected?