From be41c884b4d42934b8849afec2d608339e5a9088 Mon Sep 17 00:00:00 2001 From: Kai Tamkun <13513421+heimskr@users.noreply.github.com> Date: Fri, 21 Mar 2025 21:46:06 -0700 Subject: [PATCH] Fix `dns.resolve` (#18393) --- src/bun.js/api/bun/dns_resolver.zig | 4 ++-- src/js/node/dns.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/bun.js/api/bun/dns_resolver.zig b/src/bun.js/api/bun/dns_resolver.zig index f184e8851c..7f1ba9a46a 100644 --- a/src/bun.js/api/bun/dns_resolver.zig +++ b/src/bun.js/api/bun/dns_resolver.zig @@ -2501,7 +2501,7 @@ pub const DNSResolver = struct { return globalThis.throwNotEnoughArguments("resolve", 3, arguments.len); } - const record_type: RecordType = if (arguments.len == 1) + const record_type: RecordType = if (arguments.len <= 1) RecordType.default else brk: { const record_type_value = arguments.ptr[1]; @@ -2518,7 +2518,7 @@ pub const DNSResolver = struct { } break :brk RecordType.map.getWithEql(record_type_str.getZigString(globalThis), JSC.ZigString.eqlComptime) orelse { - return globalThis.throwInvalidArgumentType("resolve", "record", "one of: A, AAAA, CAA, CNAME, MX, NS, PTR, SOA, SRV, TXT"); + return globalThis.throwInvalidArgumentType("resolve", "record", "one of: A, AAAA, ANY, CAA, CNAME, MX, NS, PTR, SOA, SRV, TXT"); }; }; diff --git a/src/js/node/dns.ts b/src/js/node/dns.ts index bc821360ce..1f839600c5 100644 --- a/src/js/node/dns.ts +++ b/src/js/node/dns.ts @@ -395,7 +395,7 @@ var InternalResolver = class Resolver { validateResolve(hostname, callback); Resolver.#getResolver(this) - .resolve(hostname) + .resolve(hostname, rrtype) .then( results => { switch (rrtype?.toLowerCase()) {