mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-15 21:32:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix two parser bugs

Browse Source 
Former-commit-id: 884b0e3e31e562e4f0e0676819c442842ba9040b
This commit is contained in:
Jarred Sumner
2021-08-11 15:54:15 -07:00
parent 3b0a19efe0
commit c3c14ff9ce
3 changed files with 22 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/js_parser/js_parser.zig
View File

@@ -3447,7 +3447,15 @@ pub fn NewParser(
item = item.getSpread().value;
}
const res = p.convertExprToBindingAndInitializer(&item, invalid_loc, is_spread);
items.append(js_ast.ArrayBinding{ .binding = res.binding orelse unreachable, .default_value = res.override_expr }) catch unreachable;
items.append(js_ast.ArrayBinding{
// It's valid for it to be missing
// An example:
// Promise.all(promises).then(([, len]) => true);
// ^ Binding is missing there
.binding = res.binding orelse p.b(B.Missing{}, item.loc),
.default_value = res.override_expr,
}) catch unreachable;
}
return p.b(B.Array{
@@ -11162,6 +11170,13 @@ pub fn NewParser(
},
.e_import => |e_| {
const state = TransposeState{
// we must check that the await_target is an e_import or it will crash
// example from next.js where not checking causes a panic:
// ```
// const {
// normalizeLocalePath,
// } = require('../shared/lib/i18n/normalize-locale-path') as typeof import('../shared/lib/i18n/normalize-locale-path')
// ```
.is_await_target = if (p.await_target != null) p.await_target.? == .e_import and p.await_target.?.e_import == e_ else false,
.is_then_catch_target = p.then_catch_chain.has_catch and std.meta.activeTag(p.then_catch_chain.next_target) == .e_import and expr.data.e_import == p.then_catch_chain.next_target.e_import,
.loc = e_.expr.loc,