mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-11 19:38:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(request) handle undefined/null/empty signal on request (#5503)

Browse Source 
* handle undefined/null/empty signal on request

* better approach
This commit is contained in:
Ciro Spaciari
2023-09-15 21:19:26 -07:00
committed by GitHub
parent b54e3f3c04
commit cb057e61ba
2 changed files with 38 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/bun.js/webcore/request.zig
View File

@@ -608,9 +608,8 @@ pub const Request = struct {
}
if (!fields.contains(.signal)) {
if (value.get(globalThis, "signal")) |signal_| {
if (value.getTruthy(globalThis, "signal")) |signal_| {
fields.insert(.signal);
if (AbortSignal.fromJS(signal_)) |signal| {
//Keep it alive
signal_.ensureStillAlive();