From cce6cfb2b3efb78e291a3373ef929fea35e914cf Mon Sep 17 00:00:00 2001 From: Dylan Conway <35280289+dylan-conway@users.noreply.github.com> Date: Wed, 13 Mar 2024 14:50:31 -0700 Subject: [PATCH] fix integer overflow on subprocess deinit (#9388) * avoid overflow * closeWithoutReporting * PipeWriter too * remove comment --- src/io/PipeReader.zig | 2 +- src/io/PipeWriter.zig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/io/PipeReader.zig b/src/io/PipeReader.zig index 3ab76f645b..1a333dbc0e 100644 --- a/src/io/PipeReader.zig +++ b/src/io/PipeReader.zig @@ -790,7 +790,7 @@ const PosixBufferedReader = struct { pub fn deinit(this: *PosixBufferedReader) void { this.buffer().clearAndFree(); - this.closeHandle(); + this.closeWithoutReporting(); } pub fn onError(this: *PosixBufferedReader, err: bun.sys.Error) void { diff --git a/src/io/PipeWriter.zig b/src/io/PipeWriter.zig index 4805d165fb..342b81ad14 100644 --- a/src/io/PipeWriter.zig +++ b/src/io/PipeWriter.zig @@ -653,7 +653,7 @@ pub fn PosixStreamingWriter( pub fn deinit(this: *PosixWriter) void { this.buffer.clearAndFree(); - this.close(); + this.closeWithoutReporting(); } pub fn hasRef(this: *PosixWriter) bool {