mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-13 04:18:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(windows) socket and timers/performance tests (#9651)

Browse Source 
* WIP missing keepalive

* cleanup

* is a Bun.sleep bug?

* no bun sleep

* fix exception

* revert

* fix setTimeout/Bun.sleep

* add Bun.sleep keepalive test

* fixes

* one more bonus fix

* fix early firing of timers

* use localhost and pass the server.hostname

* opsie
This commit is contained in:
Ciro Spaciari
2024-03-27 14:31:12 -03:00
committed by GitHub
parent aee8eeaf45
commit d030cce8bb
8 changed files with 66 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/shell/subproc.zig
View File

@@ -1206,7 +1206,7 @@ pub const PipeReader = struct {
const owned = this.toOwnedSlice();
this.state = .{ .done = owned };
if (!this.isDone()) return;
// we need to ref because the process might be done and deref inside signalDoneToCmd before we call onCloseIO
// we need to ref because the process might be done and deref inside signalDoneToCmd and we wanna to keep it alive to check this.process
this.ref();
defer this.deref();
this.trySignalDoneToCmd();
@@ -1325,6 +1325,9 @@ pub const PipeReader = struct {
bun.default_allocator.free(this.state.done);
}
this.state = .{ .err = err.toSystemError() };
// we need to ref because the process might be done and deref inside signalDoneToCmd and we wanna to keep it alive to check this.process
this.ref();
defer this.deref();
this.trySignalDoneToCmd();
if (this.process) |process| {
// this.process = null;