From d1da677eff7a5cd9d4351cb5b2298e82ce008a9f Mon Sep 17 00:00:00 2001 From: Don Isaac Date: Wed, 9 Apr 2025 11:47:48 -0700 Subject: [PATCH] pr comments --- src/semver/Version.zig | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/semver/Version.zig b/src/semver/Version.zig index a857bb8f36..312f3b75ec 100644 --- a/src/semver/Version.zig +++ b/src/semver/Version.zig @@ -25,6 +25,8 @@ const assert = bun.assert; pub const Version = extern struct { major: u32 = 0, minor: u32 = 0, + /// Some packages use the current date, e.g. `20241225` to make the patch number unique. Some + /// dates are large enough to overflow a u32. patch: u64 = 0, tag: Tag = .{}, @@ -265,9 +267,6 @@ pub const Version = extern struct { }; } - pub fn fmt(this: *const Partial, input: string) Formatter { - return .{ .version = this.min(), .input = input }; - } pub const PartialFormatter = struct { version: Partial, input: string,