From d3dad085f3fc0865a84fe6507a29a02fa55bd2ee Mon Sep 17 00:00:00 2001 From: Colin McDonnell Date: Fri, 7 Apr 2023 15:11:12 -0700 Subject: [PATCH] engine -> app --- docs/rfcs/{bun-engine.ts => bun-app.ts} | 12 ++++++------ docs/rfcs/bun-bundler.ts | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) rename docs/rfcs/{bun-engine.ts => bun-app.ts} (92%) diff --git a/docs/rfcs/bun-engine.ts b/docs/rfcs/bun-app.ts similarity index 92% rename from docs/rfcs/bun-engine.ts rename to docs/rfcs/bun-app.ts index 957dfab452..75e5c5411a 100644 --- a/docs/rfcs/bun-engine.ts +++ b/docs/rfcs/bun-app.ts @@ -2,7 +2,7 @@ import { FileBlob, ServeOptions, Server } from "bun"; import { BuildManifest, BuildOptions, BuildResult, BundlerOptions, LazyBuildResult } from "./bun-bundler"; -interface EngineOptions extends BuildOptions { +interface AppOptions extends BuildOptions { build?: boolean; // disable building/bundling serve?: Array< | { @@ -18,8 +18,8 @@ interface EngineOptions extends BuildOptions { >; } -export declare class Engine { - constructor(options: EngineOptions | (EngineOptions | undefined)[]); +export declare class App { + constructor(options: AppOptions | (AppOptions | undefined)[]); // start dev server serve(options: Partial): Promise; // run full build @@ -37,7 +37,7 @@ export declare class Engine { // simple static file server { - const server = new Engine([ + const server = new App([ { name: "static server", // disable all buildling @@ -73,7 +73,7 @@ export declare class Engine { * return new Response("hello world"); * } */ - const app = new Engine([ + const app = new App([ { name: "simple HTTP server", target: "bun", @@ -118,7 +118,7 @@ export declare class Engine { style: "nextjs", }); - const app = new Engine([ + const app = new App([ { name: "SSR'd react, pages dir", target: "bun", diff --git a/docs/rfcs/bun-bundler.ts b/docs/rfcs/bun-bundler.ts index 10ffba6da7..e022cc96e7 100644 --- a/docs/rfcs/bun-bundler.ts +++ b/docs/rfcs/bun-bundler.ts @@ -124,7 +124,7 @@ export interface BuildOptions extends BundlerOptions { manifest?: boolean; // inputs - entrypoints: string[]; + entrypoints?: string[]; rootDir?: string; // equiv. outbase naming?: