From d5e6ff4c973bfbe7398baaef86bcdb73fc731589 Mon Sep 17 00:00:00 2001 From: Ashcon Partovi Date: Wed, 17 Apr 2024 10:04:57 -0700 Subject: [PATCH] Fix artifact uploads for canary builds --- .github/workflows/ci.yml | 2 +- .github/workflows/upload.yml | 17 ++++++++++++----- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ac80625d9a..07bac91135 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -190,7 +190,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Cleanup Artifacts - uses: geekyeggo/delete-artifact@v2 + uses: geekyeggo/delete-artifact@v5 with: name: | bun-*-cpp diff --git a/.github/workflows/upload.yml b/.github/workflows/upload.yml index f9bb5ca158..1457afe4f9 100644 --- a/.github/workflows/upload.yml +++ b/.github/workflows/upload.yml @@ -12,6 +12,7 @@ on: jobs: upload: if: ${{ github.repository_owner == 'oven-sh' }} + name: Upload Artifacts runs-on: ubuntu-latest steps: - name: Download Artifacts @@ -23,12 +24,18 @@ jobs: github-token: ${{ github.token }} run-id: ${{ github.event.workflow_run.id }} - name: Upload to GitHub Releases - uses: softprops/action-gh-release@v2 + uses: ncipollo/release-action@v1 with: - tag_name: canary - make_latest: false - generate_release_notes: false - files: bun/* + tag: canary + name: Canary (${{ github.sha }}) + prerelease: true + body: This canary release of Bun corresponds to the commit [${{ github.sha }}] + allowUpdates: true + replacesArtifacts: true + generateReleaseNotes: true + artifactErrorsFailBuild: true + artifacts: bun/**/bun-*.zip + token: ${{ github.token }} - name: Upload to S3 (using SHA) uses: shallwefootball/s3-upload-action@4350529f410221787ccf424e50133cbc1b52704e with: