mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-09 18:38:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix a small memory leak when requiring CommonJS modules (#12984)

Browse Source
This commit is contained in:
Jarred Sumner
2024-07-31 22:30:01 -07:00
committed by GitHub
parent 49ab4c147a
commit dc620ea837
8 changed files with 34 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/bun.js/bindings/ModuleLoader.cpp
View File

@@ -430,7 +430,7 @@ extern "C" void Bun__onFulfillAsyncModule(
}
}
if (res->result.value.commonJSExportsLen) {
if (res->result.value.isCommonJSModule) {
auto created = Bun::createCommonJSModule(jsCast<Zig::GlobalObject*>(globalObject), specifierValue, res->result.value);
if (created.has_value()) {
JSSourceCode* code = JSSourceCode::create(vm, WTFMove(created.value()));
@@ -602,7 +602,7 @@ JSValue fetchCommonJSModule(
Bun__transpileFile(bunVM, globalObject, specifier, referrer, typeAttribute, res, false);
getSourceCodeStringForDeref();
if (res->success && res->result.value.commonJSExportsLen) {
if (res->success && res->result.value.isCommonJSModule) {
target->evaluate(globalObject, specifier->toWTFString(BunString::ZeroCopy), res->result.value);
RETURN_IF_EXCEPTION(scope, {});
RELEASE_AND_RETURN(scope, target);
@@ -774,7 +774,7 @@ static JSValue fetchESMSourceCode(
getSourceCodeStringForDeref();
}
if (res->success && res->result.value.commonJSExportsLen) {
if (res->success && res->result.value.isCommonJSModule) {
auto created = Bun::createCommonJSModule(globalObject, specifierJS, res->result.value);
if (created.has_value()) {