mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-13 12:29:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

zig: prefer .jsUndefined() over .undefined for JSValue (#20332)

Browse Source
This commit is contained in:
Meghan Denny
2025-06-12 12:18:46 -08:00
committed by GitHub
parent d6590c4bfa
commit dedd433cbf
84 changed files with 569 additions and 574 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/bun.js/ConsoleObject.zig
View File

@@ -184,7 +184,7 @@ fn messageWithTypeAndLevel_(
// if value is not an object/array/iterable, don't print a table and just print it
var tabular_data = vals[0];
if (tabular_data.isObject()) {
const properties = if (len >= 2 and vals[1].jsType().isArray()) vals[1] else JSValue.undefined;
const properties: JSValue = if (len >= 2 and vals[1].jsType().isArray()) vals[1] else .jsUndefined();
var table_printer = TablePrinter.init(
global,
level,
@@ -1339,7 +1339,7 @@ pub const Formatter = struct {
.ProxyObject => tag: {
const handler = value.getProxyInternalField(.handler);
if (handler == .zero or handler == .undefined or handler == .null) {
if (handler == .zero or handler.isUndefinedOrNull()) {
break :tag .RevokedProxy;
}
break :tag .Proxy;
@@ -2606,7 +2606,7 @@ pub const Formatter = struct {
}
// this case should never happen
return try this.printAs(.Undefined, Writer, writer_, .undefined, .Cell, enable_ansi_colors);
return try this.printAs(.Undefined, Writer, writer_, .jsUndefined(), .Cell, enable_ansi_colors);
} else if (value.as(bun.api.Timer.TimeoutObject)) |timer| {
this.addForNewLine("Timeout(# ) ".len + bun.fmt.fastDigitCount(@as(u64, @intCast(@max(timer.internals.id, 0)))));
if (timer.internals.flags.kind == .setInterval) {
@@ -2895,13 +2895,13 @@ pub const Formatter = struct {
writer.print("{}", .{str});
},
.Event => {
const event_type_value = brk: {
const value_ = value.get_unsafe(this.globalThis, "type") orelse break :brk JSValue.undefined;
const event_type_value: JSValue = brk: {
const value_ = value.get_unsafe(this.globalThis, "type") orelse break :brk .jsUndefined();
if (value_.isString()) {
break :brk value_;
}
break :brk JSValue.undefined;
break :brk .jsUndefined();
};
const event_type = switch (try EventType.map.fromJS(this.globalThis, event_type_value) orelse .unknown) {
@@ -2972,7 +2972,7 @@ pub const Formatter = struct {
comptime Output.prettyFmt("<r><blue>data<d>:<r> ", enable_ansi_colors),
.{},
);
const data = (try value.fastGet(this.globalThis, .data)) orelse JSValue.undefined;
const data: JSValue = (try value.fastGet(this.globalThis, .data)) orelse .jsUndefined();
const tag = Tag.getAdvanced(data, this.globalThis, .{
.hide_global = true,
.disable_inspect_custom = this.disable_inspect_custom,