mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-14 21:01:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

zig: prefer .jsUndefined() over .undefined for JSValue (#20332)

Browse Source
This commit is contained in:
Meghan Denny
2025-06-12 12:18:46 -08:00
committed by GitHub
parent d6590c4bfa
commit dedd433cbf
84 changed files with 569 additions and 574 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/bun.js/webcore/ReadableStream.zig
View File

@@ -570,7 +570,7 @@ pub fn NewSource(
bun.assert(flag.isBoolean());
}
return switch (this.context.setRawMode(flag == .true)) {
.result => .undefined,
.result => .jsUndefined(),
.err => |e| e.toJSC(global),
};
}
@@ -618,7 +618,7 @@ pub fn NewSource(
const view = arguments.ptr[0];
view.ensureStillAlive();
this.this_jsvalue = this_jsvalue;
var buffer = view.asArrayBuffer(globalThis) orelse return .undefined;
var buffer = view.asArrayBuffer(globalThis) orelse return .jsUndefined();
return processResult(
this_jsvalue,
globalThis,
@@ -679,7 +679,7 @@ pub fn NewSource(
JSC.markBinding(@src());
this.this_jsvalue = callFrame.this();
this.cancel();
return .undefined;
return .jsUndefined();
}
pub fn setOnCloseFromJS(this: *ReadableStreamSourceType, globalObject: *JSC.JSGlobalObject, value: JSC.JSValue) bun.JSError!void {
@@ -704,7 +704,7 @@ pub fn NewSource(
this.globalThis = globalObject;
if (value.isUndefined()) {
js.onDrainCallbackSetCached(this.this_jsvalue, globalObject, .undefined);
js.onDrainCallbackSetCached(this.this_jsvalue, globalObject, .jsUndefined());
return;
}
@@ -720,7 +720,7 @@ pub fn NewSource(
JSC.markBinding(@src());
return this.close_jsvalue.get() orelse .undefined;
return this.close_jsvalue.get() orelse .jsUndefined();
}
pub fn getOnDrainFromJS(this: *ReadableStreamSourceType, globalObject: *JSC.JSGlobalObject) JSC.JSValue {
@@ -732,7 +732,7 @@ pub fn NewSource(
return val;
}
return .undefined;
return .jsUndefined();
}
pub fn updateRef(this: *ReadableStreamSourceType, globalObject: *JSGlobalObject, callFrame: *JSC.CallFrame) bun.JSError!JSC.JSValue {
@@ -742,7 +742,7 @@ pub fn NewSource(
const ref_or_unref = callFrame.argument(0).toBoolean();
this.setRef(ref_or_unref);
return .undefined;
return .jsUndefined();
}
fn onClose(ptr: ?*anyopaque) void {